Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: dart/tools/test.dart

Issue 23436004: Reduce the number of processes/tests run in parallel by test.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/test.dart
diff --git a/dart/tools/test.dart b/dart/tools/test.dart
index 03bb4e993e1c244b5a5169fb4f71faa54f93869f..acd42b7f6d513769a98de6fd98830c4590ab9731 100755
--- a/dart/tools/test.dart
+++ b/dart/tools/test.dart
@@ -154,10 +154,12 @@ void testConfigurations(List<Map> configurations) {
}
}
- // There should not be more than one InternetExplorerDriver instance
- // running at a time. For details, see
- // http://code.google.com/p/selenium/wiki/InternetExplorerDriver.
- if (conf['runtime'].startsWith('ie') && !conf["use_browser_controller"]) {
+ if (conf['runtime'].startsWith('ie')) {
+ // NOTE: We've experienced random timeouts of tests on ie9/ie10. The
+ // underlying issue has not been determined yet. Our current hypothesis
+ // is that windows makes bad scheduling decisions if we overload a
+ // machine (i.e. some processes seem to starve).
+ maxProcesses = math.max(1, maxProcesses-2);
maxBrowserProcesses = 1;
} else if (conf['runtime'].startsWith('safari') &&
conf['use_browser_controller']) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698