Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2343593002: Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests. (Closed)

Created:
4 years, 3 months ago by yamaguchi
Modified:
4 years, 3 months ago
Reviewers:
satorux1, Yuta Kitamura
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests. (patchset #4 id:60001 of https://codereview.chromium.org/2333983004/ ) Reason for revert: Asan failure Original issue's description: > Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock class of DiskMountManagerObserver. > > This change is based on > https://codereview.chromium.org/2292473002/ > which was once merged but reverted by > https://codereview.chromium.org/2340433002/ > > BUG=641943 > > Committed: https://crrev.com/a07c4fb1ece6ee6c6a2170825208b1f873012a0a > Cr-Commit-Position: refs/heads/master@{#418478} TBR=satorux@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641943 Committed: https://crrev.com/48ec0aa3ee5b7ab7efe7738cd03b243bd5874c62 Cr-Commit-Position: refs/heads/master@{#418520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -402 lines) Patch
M chromeos/disks/disk_mount_manager_unittest.cc View 18 chunks +221 lines, -402 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
yamaguchi
Created Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests.
4 years, 3 months ago (2016-09-14 09:51:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343593002/1
4 years, 3 months ago (2016-09-14 09:51:38 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-14 09:51:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343593002/1
4 years, 3 months ago (2016-09-14 09:58:45 UTC) #7
Yuta Kitamura
LGTM
4 years, 3 months ago (2016-09-14 09:58:45 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-14 09:58:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343593002/1
4 years, 3 months ago (2016-09-14 10:00:19 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 10:01:10 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 10:03:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48ec0aa3ee5b7ab7efe7738cd03b243bd5874c62
Cr-Commit-Position: refs/heads/master@{#418520}

Powered by Google App Engine
This is Rietveld 408576698