Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: components/ntp_snippets/ntp_snippets_status_service.cc

Issue 2343583002: Change the default value of the fetching_requires_signin parameter (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippets_status_service.cc
diff --git a/components/ntp_snippets/ntp_snippets_status_service.cc b/components/ntp_snippets/ntp_snippets_status_service.cc
index cb50a9aacdb4de2faaf1410aa8a57d6e830c5bb2..9b6006cbaa92109af34ee527fb8466782a1ee675 100644
--- a/components/ntp_snippets/ntp_snippets_status_service.cc
+++ b/components/ntp_snippets/ntp_snippets_status_service.cc
@@ -26,16 +26,16 @@ NTPSnippetsStatusService::NTPSnippetsStatusService(
SigninManagerBase* signin_manager,
PrefService* pref_service)
: disabled_reason_(DisabledReason::EXPLICITLY_DISABLED),
- require_signin_(true),
+ require_signin_(false),
signin_manager_(signin_manager),
pref_service_(pref_service),
signin_observer_(this) {
std::string param_value_str = variations::GetVariationParamValueByFeature(
kArticleSuggestionsFeature, kFetchingRequiresSignin);
- if (param_value_str == kFetchingRequiresSigninDisabled) {
- require_signin_ = false;
+ if (param_value_str == kFetchingRequiresSigninEnabled) {
+ require_signin_ = true;
} else if (!param_value_str.empty() &&
- param_value_str != kFetchingRequiresSigninEnabled) {
+ param_value_str != kFetchingRequiresSigninDisabled) {
DLOG(WARNING) << "Unknow value for the variations parameter "
<< kFetchingRequiresSignin << ": " << param_value_str;
}

Powered by Google App Engine
This is Rietveld 408576698