Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2343563004: webrtc/api/rtcstats[report].h is moving to webrtc/api/stats/ (Closed)

Created:
4 years, 3 months ago by hbos_chromium
Modified:
4 years, 3 months ago
Reviewers:
esprehn, perkj_webrtc
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webrtc/api/rtcstats[report].h is moving to webrtc/api/stats/ Soon a roll will move these files, keeping the old files as pseudonyms for the new include path as to not break chromium. This updates inclusions of these files so that they can be removed after another WebRTC roll. BUG=chromium:627816 Committed: https://crrev.com/aa6e76c4bcf68375d965e293f60f92cd271bdc2a Cr-Commit-Position: refs/heads/master@{#419722}

Patch Set 1 #

Patch Set 2 : Added dependency on rtc_stats_api for the headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/renderer/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webrtc/rtc_stats.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/rtc_stats.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
hbos_chromium
Please take a look perkj. Starting review now so that I can land this as ...
4 years, 3 months ago (2016-09-15 14:56:38 UTC) #2
perkj_webrtc
lgtm
4 years, 3 months ago (2016-09-16 09:13:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343563004/1
4 years, 3 months ago (2016-09-18 06:51:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/130805) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 3 months ago (2016-09-18 06:54:59 UTC) #7
hbos_chromium
+esprehn for BUILD.gn, please take a look
4 years, 3 months ago (2016-09-18 07:04:08 UTC) #9
hbos_chromium
Ping esprehn
4 years, 3 months ago (2016-09-20 08:40:31 UTC) #14
esprehn
lgtm
4 years, 3 months ago (2016-09-20 10:52:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343563004/20001
4 years, 3 months ago (2016-09-20 11:10:06 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 12:23:49 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 12:26:58 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa6e76c4bcf68375d965e293f60f92cd271bdc2a
Cr-Commit-Position: refs/heads/master@{#419722}

Powered by Google App Engine
This is Rietveld 408576698