third_party/WebKit/Source/core/timing/PerformanceObserver.cpp - Issue 2343553005: enable / disable Long Task instrumentation based on presence of LongTask observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceObserver.cpp

Issue 2343553005: enable / disable Long Task instrumentation based on presence of LongTask observer (Closed)

Patch Set: address review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/timing/PerformanceObserver.cpp

diff --git a/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp b/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp

index 920a8d5ce3e84a6acd3a792946ff2c0fbc6d8802..47aaa0f7da2f1e7b58d4fed95d7165dfb294c30c 100644

--- a/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp

+++ b/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp

@@ -57,9 +57,9 @@ void PerformanceObserver::observe(const PerformanceObserverInit& observerInit, E

void PerformanceObserver::disconnect()

{

- if (m_performance)

+ if (m_performance) {

m_performance->unregisterPerformanceObserver(*this);

+ }

m_performanceEntries.clear();

m_isRegistered = false;

}