Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2343553002:
Rename m_frame to m_frameRect. (Closed)
DescriptionRename m_frame to m_frameRect.
It is both clearer this way, and it avoids shadowing by the identically-named
m_frame in FrameView.
TBR=drott
Committed: https://crrev.com/d29d5bd8f5ae19d45d0b75a8a6c415d50b91a711
Cr-Commit-Position: refs/heads/master@{#418960}
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
wkorman@chromium.org changed reviewers: + szager@chromium.org, wangxianzhu@chromium.org
As per szager@ request earlier today.
The CQ bit was checked by szager@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by wkorman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
wkorman@chromium.org changed reviewers: + drott@chromium.org
+drott for platform OWNERS.
wkorman@chromium.org changed reviewers: + fmalita@chromium.org - drott@chromium.org, wangxianzhu@chromium.org
+fmalita for platform OWNERS.
Description was changed from ========== Rename m_frame to m_frameRect. It is both clearer this way, and it avoids shadowing by the identically-named m_frame in FrameView. ========== to ========== Rename m_frame to m_frameRect. It is both clearer this way, and it avoids shadowing by the identically-named m_frame in FrameView. TBR=drott ==========
The CQ bit was checked by wkorman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Rename m_frame to m_frameRect. It is both clearer this way, and it avoids shadowing by the identically-named m_frame in FrameView. TBR=drott ========== to ========== Rename m_frame to m_frameRect. It is both clearer this way, and it avoids shadowing by the identically-named m_frame in FrameView. TBR=drott ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Rename m_frame to m_frameRect. It is both clearer this way, and it avoids shadowing by the identically-named m_frame in FrameView. TBR=drott ========== to ========== Rename m_frame to m_frameRect. It is both clearer this way, and it avoids shadowing by the identically-named m_frame in FrameView. TBR=drott Committed: https://crrev.com/d29d5bd8f5ae19d45d0b75a8a6c415d50b91a711 Cr-Commit-Position: refs/heads/master@{#418960} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d29d5bd8f5ae19d45d0b75a8a6c415d50b91a711 Cr-Commit-Position: refs/heads/master@{#418960} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
