Various cleanup of ContainerNode.cpp

Various cleanup of ContainerNode.cpp

* Mark collectChildrenAndRemoveFromOldParent |inline|
  There is only one callsite.

* collectChildrenAndRemoveFromOldParentWithCheck() returns bool
  It makes callsites simpler.

* We don't need to return |nullptr| in a case of hadException().
  Callsites should check hadException() before referring the return value.

* Remove useless local variables.

* Use functors in parseInsertBefore() and parserAppendChild().

This CL has no behavior changes.

Committed: https://crrev.com/6325fbd1e42548d6071cf29f21642820e1ecba00
Cr-Commit-Position: refs/heads/master@{#418757}

[tkent, 2016-09-14 01:35:57]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 01:36:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-09-14 01:43:06]

Description was changed from

==========
Various cleanup of ContainerNode.cpp

BUG=
==========

to

==========
Various cleanup of ContainerNode.cpp

* Mark collectChildrenAndRemoveFromOldParent |inline|
  There are only one callsite.

* collectChildrenAndRemoveFromOldParentWithCheck() returns bool
  It makes callsites simpler.

* We don't need to return |nullptr| in a case of hadException().
  Callsites should check hadException() before referring the return value.

BUG=
==========

[tkent, 2016-09-14 01:44:33]

Description was changed from

==========
Various cleanup of ContainerNode.cpp

* Mark collectChildrenAndRemoveFromOldParent |inline|
  There are only one callsite.

* collectChildrenAndRemoveFromOldParentWithCheck() returns bool
  It makes callsites simpler.

* We don't need to return |nullptr| in a case of hadException().
  Callsites should check hadException() before referring the return value.

BUG=
==========

to

==========
Various cleanup of ContainerNode.cpp

* Mark collectChildrenAndRemoveFromOldParent |inline|
  There are only one callsite.

* collectChildrenAndRemoveFromOldParentWithCheck() returns bool
  It makes callsites simpler.

* We don't need to return |nullptr| in a case of hadException().
  Callsites should check hadException() before referring the return value.

* Remove useless local variables.

* Use functors in parseInsertBefore() and parserAppendChild().

This CL has no behavior changes.
==========

[tkent, 2016-09-14 01:44:54]

Description was changed from

==========
Various cleanup of ContainerNode.cpp

* Mark collectChildrenAndRemoveFromOldParent |inline|
  There are only one callsite.

* collectChildrenAndRemoveFromOldParentWithCheck() returns bool
  It makes callsites simpler.

* We don't need to return |nullptr| in a case of hadException().
  Callsites should check hadException() before referring the return value.

* Remove useless local variables.

* Use functors in parseInsertBefore() and parserAppendChild().

This CL has no behavior changes.
==========

to

==========
Various cleanup of ContainerNode.cpp

* Mark collectChildrenAndRemoveFromOldParent |inline|
  There is only one callsite.

* collectChildrenAndRemoveFromOldParentWithCheck() returns bool
  It makes callsites simpler.

* We don't need to return |nullptr| in a case of hadException().
  Callsites should check hadException() before referring the return value.

* Remove useless local variables.

* Use functors in parseInsertBefore() and parserAppendChild().

This CL has no behavior changes.
==========

[commit-bot: I haz the power, 2016-09-14 02:12:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 02:12:50]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2016-09-14 02:16:09]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 02:16:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-09-14 03:14:41]

Patchset #1 (id:1) has been deleted

[tkent, 2016-09-14 03:14:48]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-09-14 03:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 03:45:41]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-09-14 03:57:59]

tkent@chromium.org changed reviewers:
+ hayato@chromium.org

[tkent, 2016-09-14 03:58:00]

hayato@, would you review this please?

[hayato, 2016-09-15 01:53:31]

lgtm

[tkent, 2016-09-15 01:57:05]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-09-15 01:57:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 02:09:10]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-09-15 02:12:43]

Description was changed from

==========
Various cleanup of ContainerNode.cpp

* Mark collectChildrenAndRemoveFromOldParent |inline|
  There is only one callsite.

* collectChildrenAndRemoveFromOldParentWithCheck() returns bool
  It makes callsites simpler.

* We don't need to return |nullptr| in a case of hadException().
  Callsites should check hadException() before referring the return value.

* Remove useless local variables.

* Use functors in parseInsertBefore() and parserAppendChild().

This CL has no behavior changes.
==========

to

==========
Various cleanup of ContainerNode.cpp

* Mark collectChildrenAndRemoveFromOldParent |inline|
  There is only one callsite.

* collectChildrenAndRemoveFromOldParentWithCheck() returns bool
  It makes callsites simpler.

* We don't need to return |nullptr| in a case of hadException().
  Callsites should check hadException() before referring the return value.

* Remove useless local variables.

* Use functors in parseInsertBefore() and parserAppendChild().

This CL has no behavior changes.

Committed: https://crrev.com/6325fbd1e42548d6071cf29f21642820e1ecba00
Cr-Commit-Position: refs/heads/master@{#418757}
==========

[commit-bot: I haz the power, 2016-09-15 02:12:44]

Patchset 1 (id:??) landed as
https://crrev.com/6325fbd1e42548d6071cf29f21642820e1ecba00
Cr-Commit-Position: refs/heads/master@{#418757}