Issue 23435006: Revert "Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23435006: Revert "Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes". (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes". This was reverted due to performance regressions on Sunspider and other benchmarks due to double GCs caused by the trampoline. R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16659

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -68 lines)			Patch
M	src/accessors.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	src/runtime.cc	View	8 chunks	+57 lines, -55 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 3 months ago (2013-09-11 15:17:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16659 (presubmit successful).

Expand Messages | Collapse Messages