[Sync] Fix namespaces for the sync_sessions component.

[Sync] Fix namespaces for the sync_sessions component.

Things within a component should have a namespace that matches its name.

BUG=646685
TBR=jam

Committed: https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0
Cr-Commit-Position: refs/heads/master@{#418878}

[maxbogue, 2016-09-14 17:53:33]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 17:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 18:09:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 18:09:20]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[maxbogue, 2016-09-14 18:18:33]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 18:19:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 18:43:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 18:43:40]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[maxbogue, 2016-09-14 19:30:38]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 19:31:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-09-14 20:23:10]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-09-14 20:23:11]

Sky, PTAL!

[commit-bot: I haz the power, 2016-09-14 21:03:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 21:03:16]

Dry run: This issue passed the CQ dry run.

[skym, 2016-09-14 22:29:58]

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
File chrome/browser/sync/glue/session_sync_test_helper.cc (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
chrome/browser/sync/glue/session_sync_test_helper.cc:15: namespace sync_sessions
{
Please move to components/sync_sessions before this namespace changes.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
File chrome/browser/sync/glue/session_sync_test_helper.h (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
chrome/browser/sync/glue/session_sync_test_helper.h:18: namespace sync_sessions
{
Please move to components/sync_sessions before this namespace changes.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
File chrome/browser/sync/glue/synced_window_delegate_android.h (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
chrome/browser/sync/glue/synced_window_delegate_android.h:27: 
Can you remove this newline?

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/ses...
File chrome/browser/sync/sessions/notification_service_sessions_router.cc
(right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/ses...
chrome/browser/sync/sessions/notification_service_sessions_router.cc:44:
namespace browser_sync {
Should be namespace sync_sessions

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/ses...
File chrome/browser/sync/sessions/notification_service_sessions_router.h
(right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/ses...
chrome/browser/sync/sessions/notification_service_sessions_router.h:29:
namespace browser_sync {
should be namespace sessions_sync

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/syn...
File chrome/browser/sync/sync_sessions_metrics_android.cc (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/syn...
chrome/browser/sync/sync_sessions_metrics_android.cc:41:
sync_sessions::SessionsSyncManager* sessions =
This file should probably get moved to chrome/browser/sync/sessions/ and have
the sync_sessions namespace instead.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/sessions_helper.h (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sessions_helper.h:20: namespace
sessions_helper {
Opened crbug.com/647044

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/ui/sync/...
File chrome/browser/ui/sync/browser_synced_window_delegate.cc (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/ui/sync/...
chrome/browser/ui/sync/browser_synced_window_delegate.cc:15: //
BrowserSyncedWindowDelegate implementations
Can you remove this? I don't think we put this kind of line in .cc files
anymore.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/ui/sync/...
File chrome/browser/ui/sync/browser_synced_window_delegates_getter.h (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/ui/sync/...
chrome/browser/ui/sync/browser_synced_window_delegates_getter.h:15: 
Okay, I think we need to decide, does chrome/browser/ui/sync/* get the
browser_sync namespace? Or not? Every file in here should be consistent, imo.

[maxbogue, 2016-09-15 00:43:54]

Updated and moved those files. PTAL!

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
File chrome/browser/sync/glue/session_sync_test_helper.cc (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
chrome/browser/sync/glue/session_sync_test_helper.cc:15: namespace sync_sessions
{
On 2016/09/14 22:29:58, skym wrote:
> Please move to components/sync_sessions before this namespace changes.

Done.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
File chrome/browser/sync/glue/session_sync_test_helper.h (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
chrome/browser/sync/glue/session_sync_test_helper.h:18: namespace sync_sessions
{
On 2016/09/14 22:29:58, skym wrote:
> Please move to components/sync_sessions before this namespace changes.

Done.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
File chrome/browser/sync/glue/synced_window_delegate_android.h (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/glu...
chrome/browser/sync/glue/synced_window_delegate_android.h:27: 
On 2016/09/14 22:29:58, skym wrote:
> Can you remove this newline?

Done.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/ses...
File chrome/browser/sync/sessions/notification_service_sessions_router.cc
(right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/ses...
chrome/browser/sync/sessions/notification_service_sessions_router.cc:44:
namespace browser_sync {
On 2016/09/14 22:29:58, skym wrote:
> Should be namespace sync_sessions

Done.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/ses...
File chrome/browser/sync/sessions/notification_service_sessions_router.h
(right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/ses...
chrome/browser/sync/sessions/notification_service_sessions_router.h:29:
namespace browser_sync {
On 2016/09/14 22:29:58, skym wrote:
> should be namespace sessions_sync

Done.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/syn...
File chrome/browser/sync/sync_sessions_metrics_android.cc (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/syn...
chrome/browser/sync/sync_sessions_metrics_android.cc:41:
sync_sessions::SessionsSyncManager* sessions =
On 2016/09/14 22:29:58, skym wrote:
> This file should probably get moved to chrome/browser/sync/sessions/ and have
> the sync_sessions namespace instead.

Done.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/sessions_helper.h (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sessions_helper.h:20: namespace
sessions_helper {
On 2016/09/14 22:29:58, skym wrote:
> Opened crbug.com/647044

Acknowledged.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/ui/sync/...
File chrome/browser/ui/sync/browser_synced_window_delegate.cc (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/ui/sync/...
chrome/browser/ui/sync/browser_synced_window_delegate.cc:15: //
BrowserSyncedWindowDelegate implementations
On 2016/09/14 22:29:58, skym wrote:
> Can you remove this? I don't think we put this kind of line in .cc files
> anymore.

Done.

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/ui/sync/...
File chrome/browser/ui/sync/browser_synced_window_delegates_getter.h (right):

https://codereview.chromium.org/2343463003/diff/40001/chrome/browser/ui/sync/...
chrome/browser/ui/sync/browser_synced_window_delegates_getter.h:15: 
On 2016/09/14 22:29:58, skym wrote:
> Okay, I think we need to decide, does chrome/browser/ui/sync/* get the
> browser_sync namespace? Or not? Every file in here should be consistent, imo.

I really don't know why half that stuff doesn't even have a namespace. I'd
rather not change it for now though.

[maxbogue, 2016-09-15 00:48:36]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 00:50:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 00:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:56:18]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[maxbogue, 2016-09-15 03:25:05]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 03:25:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 04:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 04:14:49]

Dry run: This issue passed the CQ dry run.

[skym, 2016-09-15 15:21:51]

lgtm

[maxbogue, 2016-09-15 15:46:38]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-09-15 15:46:46]

The CQ bit was unchecked by maxbogue@chromium.org

[maxbogue, 2016-09-15 15:50:42]

maxbogue@chromium.org changed reviewers:
+ jam@chromium.org

[maxbogue, 2016-09-15 15:50:42]

TBR'ing jam@ for all non-sync files.

[maxbogue, 2016-09-15 15:50:54]

Description was changed from

==========
[Sync] Fix namespaces for the sync_sessions component.

Things within a component should have a namespace that matches its name.

BUG=646685
==========

to

==========
[Sync] Fix namespaces for the sync_sessions component.

Things within a component should have a namespace that matches its name.

BUG=646685
TBR=jam
==========

[maxbogue, 2016-09-15 15:51:30]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-09-15 15:51:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 15:59:33]

Description was changed from

==========
[Sync] Fix namespaces for the sync_sessions component.

Things within a component should have a namespace that matches its name.

BUG=646685
TBR=jam
==========

to

==========
[Sync] Fix namespaces for the sync_sessions component.

Things within a component should have a namespace that matches its name.

BUG=646685
TBR=jam
==========

[commit-bot: I haz the power, 2016-09-15 15:59:35]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-15 17:01:56]

Description was changed from

==========
[Sync] Fix namespaces for the sync_sessions component.

Things within a component should have a namespace that matches its name.

BUG=646685
TBR=jam
==========

to

==========
[Sync] Fix namespaces for the sync_sessions component.

Things within a component should have a namespace that matches its name.

BUG=646685
TBR=jam

Committed: https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0
Cr-Commit-Position: refs/heads/master@{#418878}
==========

[commit-bot: I haz the power, 2016-09-15 17:01:58]

Patchset 6 (id:??) landed as
https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0
Cr-Commit-Position: refs/heads/master@{#418878}