Ignore commented-out histograms in find_unmapped_histograms.py

Ignore commented-out histograms in find_unmapped_histograms.py

The source code currently contains 4 histograms that are commented out
for documentation purposes. These should not be treated as unmapped
histograms.

Change the behaviour of the script to remove comments from the whole
text of the source file before looking for histograms. Newlines in
comments are preserved so that line number information is not lost.

Before/after output diff:

@@ -112,8 +112,6 @@
 INFO: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc:115: DataReductionProxy.ClientConfig.AuthExpiredSessionKey - 0xbc3e8360e9a88fa3
-INFO: net/disk_cache/blockfile/histogram_macros.h:88: DiskCache.2.MyExperiment_530 - 0x96d64ee0c844abe8
-INFO: net/disk_cache/blockfile/histogram_macros.h:87: DiskCache.2.MyName - 0x375b236e75b046a3
 INFO: net/disk_cache/blockfile/block_files.cc:412: DiskCache.BlockLoad_0 - 0xc71c5b8eeddcbc13
@@ -196,7 +194,6 @@
 INFO: chrome/browser/android/history_report/usage_reports_buffer_backend.cc:42: LevelDB.Open.UsageReportsBufferBackend - 0x3c3398b51e4f2c94
-INFO: content/browser/leveldb_wrapper_impl.cc:313: LevelDBWrapper.CommitDelay - 0x7b3688b99064caf4
 INFO: chrome/browser/local_discovery/service_discovery_client_mac.mm:228: LocalDiscovery.MacBrowseCallTimes - 0x68d6ea27ac6cc254
@@ -204,7 +201,6 @@
 INFO: components/storage_monitor/media_storage_util.cc:235: MediaDeviceNotifications.DeviceInfo - 0x55f5f86156ae430d
-INFO: base/metrics/field_trial.h:27: Memory.RendererTotal - 0x2e84018fc64715ff
 INFO: chrome/browser/chromeos/preferences.cc:578: Mouse.PrimaryButtonRight.Changed - 0x102a33e3a331c943

BUG=642625
Committed: https://crrev.com/edc98c959010e4dcbe85322c6fe4900af7e9a027
Cr-Commit-Position: refs/heads/master@{#419652}

[Adam Rice, 2016-09-14 07:46:38]

ricea@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rkaplow, 2016-09-19 19:17:52]

lgtm

[Adam Rice, 2016-09-20 02:08:34]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2016-09-20 02:08:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 02:17:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 02:19:35]

Description was changed from

==========
Ignore commented-out histograms in find_unmapped_histograms.py

The source code currently contains 4 histograms that are commented out
for documentation purposes. These should not be treated as unmapped
histograms.

Change the behaviour of the script to remove comments from the whole
text of the source file before looking for histograms. Newlines in
comments are preserved so that line number information is not lost.

Before/after output diff:

@@ -112,8 +112,6 @@
 INFO:
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc:115:
DataReductionProxy.ClientConfig.AuthExpiredSessionKey - 0xbc3e8360e9a88fa3
-INFO: net/disk_cache/blockfile/histogram_macros.h:88:
DiskCache.2.MyExperiment_530 - 0x96d64ee0c844abe8
-INFO: net/disk_cache/blockfile/histogram_macros.h:87: DiskCache.2.MyName -
0x375b236e75b046a3
 INFO: net/disk_cache/blockfile/block_files.cc:412: DiskCache.BlockLoad_0 -
0xc71c5b8eeddcbc13
@@ -196,7 +194,6 @@
 INFO: chrome/browser/android/history_report/usage_reports_buffer_backend.cc:42:
LevelDB.Open.UsageReportsBufferBackend - 0x3c3398b51e4f2c94
-INFO: content/browser/leveldb_wrapper_impl.cc:313: LevelDBWrapper.CommitDelay -
0x7b3688b99064caf4
 INFO: chrome/browser/local_discovery/service_discovery_client_mac.mm:228:
LocalDiscovery.MacBrowseCallTimes - 0x68d6ea27ac6cc254
@@ -204,7 +201,6 @@
 INFO: components/storage_monitor/media_storage_util.cc:235:
MediaDeviceNotifications.DeviceInfo - 0x55f5f86156ae430d
-INFO: base/metrics/field_trial.h:27: Memory.RendererTotal - 0x2e84018fc64715ff
 INFO: chrome/browser/chromeos/preferences.cc:578:
Mouse.PrimaryButtonRight.Changed - 0x102a33e3a331c943

BUG=642625
==========

to

==========
Ignore commented-out histograms in find_unmapped_histograms.py

The source code currently contains 4 histograms that are commented out
for documentation purposes. These should not be treated as unmapped
histograms.

Change the behaviour of the script to remove comments from the whole
text of the source file before looking for histograms. Newlines in
comments are preserved so that line number information is not lost.

Before/after output diff:

@@ -112,8 +112,6 @@
 INFO:
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc:115:
DataReductionProxy.ClientConfig.AuthExpiredSessionKey - 0xbc3e8360e9a88fa3
-INFO: net/disk_cache/blockfile/histogram_macros.h:88:
DiskCache.2.MyExperiment_530 - 0x96d64ee0c844abe8
-INFO: net/disk_cache/blockfile/histogram_macros.h:87: DiskCache.2.MyName -
0x375b236e75b046a3
 INFO: net/disk_cache/blockfile/block_files.cc:412: DiskCache.BlockLoad_0 -
0xc71c5b8eeddcbc13
@@ -196,7 +194,6 @@
 INFO: chrome/browser/android/history_report/usage_reports_buffer_backend.cc:42:
LevelDB.Open.UsageReportsBufferBackend - 0x3c3398b51e4f2c94
-INFO: content/browser/leveldb_wrapper_impl.cc:313: LevelDBWrapper.CommitDelay -
0x7b3688b99064caf4
 INFO: chrome/browser/local_discovery/service_discovery_client_mac.mm:228:
LocalDiscovery.MacBrowseCallTimes - 0x68d6ea27ac6cc254
@@ -204,7 +201,6 @@
 INFO: components/storage_monitor/media_storage_util.cc:235:
MediaDeviceNotifications.DeviceInfo - 0x55f5f86156ae430d
-INFO: base/metrics/field_trial.h:27: Memory.RendererTotal - 0x2e84018fc64715ff
 INFO: chrome/browser/chromeos/preferences.cc:578:
Mouse.PrimaryButtonRight.Changed - 0x102a33e3a331c943

BUG=642625

Committed: https://crrev.com/edc98c959010e4dcbe85322c6fe4900af7e9a027
Cr-Commit-Position: refs/heads/master@{#419652}
==========

[commit-bot: I haz the power, 2016-09-20 02:19:37]

Patchset 2 (id:??) landed as
https://crrev.com/edc98c959010e4dcbe85322c6fe4900af7e9a027
Cr-Commit-Position: refs/heads/master@{#419652}