MacViews: Modify condition for setting window alpha to 0 on initial display.

MacViews: Modify condition for setting window alpha to 0 on initial display.

r417863 added a flag initial_visibility_suppressed_ to BridgedNativeWidget to
show some dialogs with an alpha value of 0 initially, till the frames from the
compositor arrive. This CL modifies the condition to set the flag and sets it
only when the widget is layer backed.

BUG=623950
Committed: https://crrev.com/4a528effa127e1db82476eeb57c57649664af9b5
Cr-Commit-Position: refs/heads/master@{#419702}

[karandeepb, 2016-09-15 12:25:14]

Description was changed from

==========
MacViews: Modify condition for setting window alpha to 0.

r417863 added a flag initial_visibility_suppressed_ to BridgedNativeWidget to
show some dialogs with an alpha value of 0 initially, till the frames from the
compositor arrive. This CL modifies the condition to set the flag, by only
setting it when the widget is layer backed.

BUG=623950
==========

to

==========
MacViews: Modify condition for setting window alpha to 0 on initial display.

r417863 added a flag initial_visibility_suppressed_ to BridgedNativeWidget to
show some dialogs with an alpha value of 0 initially, till the frames from the
compositor arrive. This CL modifies the condition to set the flag and sets it
only when the widget is layer backed.

BUG=623950
==========

[karandeepb, 2016-09-16 01:06:19]

karandeepb@chromium.org changed reviewers:
+ tapted@chromium.org

[karandeepb, 2016-09-16 01:06:19]

PTAL Trent.

[tapted, 2016-09-19 07:35:34]

Probably lgtm, but there may be some things to investigate / follow-up on

https://codereview.chromium.org/2343433005/diff/1/ui/views/cocoa/bridged_nati...
File ui/views/cocoa/bridged_native_widget.mm (right):

https://codereview.chromium.org/2343433005/diff/1/ui/views/cocoa/bridged_nati...
ui/views/cocoa/bridged_native_widget.mm:581: if (layer() && [window_ isOpaque]
&&
This reminds me a bit of https://codereview.chromium.org/2061693003/ - still a
WIP - but it would alter the states under which layer() is null. (e.g. we could
DCHECK(layer()) here, and return early before this point in the function if
bridged_view_ is ever null.)

One thing to consider: with Widget::InitParams::TYPE_CONTROL, altering this line
changes behaviour. BNW::Init() calls SetVisibilityState before
NWM::InitNativeWidget calls CreateLayer(). So, what should TYPE_CONTROL do wrt
the "flash"?

I think either
 - all TYPE_CONTROL will be transparent anyway, or
 - TYPE_CONTROL isn't used [yet] on Mac -- it was once used for the app list,
but that's no more.

Might need some investigation.

[karandeepb, 2016-09-20 08:04:51]

https://codereview.chromium.org/2343433005/diff/1/ui/views/cocoa/bridged_nati...
File ui/views/cocoa/bridged_native_widget.mm (right):

https://codereview.chromium.org/2343433005/diff/1/ui/views/cocoa/bridged_nati...
ui/views/cocoa/bridged_native_widget.mm:581: if (layer() && [window_ isOpaque]
&&
> One thing to consider: with Widget::InitParams::TYPE_CONTROL, altering this
line
> changes behaviour. BNW::Init() calls SetVisibilityState before
> NWM::InitNativeWidget calls CreateLayer(). So, what should TYPE_CONTROL do wrt
> the "flash"?

NativeWidgetAura initializes the layer before showing the window for
TYPE_CONTROL widgets -
https://cs.chromium.org/chromium/src/ui/views/widget/native_widget_aura.cc?dr....
So we seem to be diverging from its behavior. 

> I think either
>  - all TYPE_CONTROL will be transparent anyway, or
>  - TYPE_CONTROL isn't used [yet] on Mac -- it was once used for the app list,
> but that's no more.

Yeah from what I see on codesearch, most of the TYPE_CONTROL widgets are
transparent. Don't think (Not sure) there are any behind one of the MacViews
flags. An example for MacViewsBrowser is the Find In Page popup. I guess we can
defer taking a look at this, till we get an actual bug.

[karandeepb, 2016-09-20 08:06:32]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-09-20 08:06:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 08:34:13]

Description was changed from

==========
MacViews: Modify condition for setting window alpha to 0 on initial display.

r417863 added a flag initial_visibility_suppressed_ to BridgedNativeWidget to
show some dialogs with an alpha value of 0 initially, till the frames from the
compositor arrive. This CL modifies the condition to set the flag and sets it
only when the widget is layer backed.

BUG=623950
==========

to

==========
MacViews: Modify condition for setting window alpha to 0 on initial display.

r417863 added a flag initial_visibility_suppressed_ to BridgedNativeWidget to
show some dialogs with an alpha value of 0 initially, till the frames from the
compositor arrive. This CL modifies the condition to set the flag and sets it
only when the widget is layer backed.

BUG=623950
==========

[commit-bot: I haz the power, 2016-09-20 08:34:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 08:37:08]

Description was changed from

==========
MacViews: Modify condition for setting window alpha to 0 on initial display.

r417863 added a flag initial_visibility_suppressed_ to BridgedNativeWidget to
show some dialogs with an alpha value of 0 initially, till the frames from the
compositor arrive. This CL modifies the condition to set the flag and sets it
only when the widget is layer backed.

BUG=623950
==========

to

==========
MacViews: Modify condition for setting window alpha to 0 on initial display.

r417863 added a flag initial_visibility_suppressed_ to BridgedNativeWidget to
show some dialogs with an alpha value of 0 initially, till the frames from the
compositor arrive. This CL modifies the condition to set the flag and sets it
only when the widget is layer backed.

BUG=623950

Committed: https://crrev.com/4a528effa127e1db82476eeb57c57649664af9b5
Cr-Commit-Position: refs/heads/master@{#419702}
==========

[commit-bot: I haz the power, 2016-09-20 08:37:10]

Patchset 1 (id:??) landed as
https://crrev.com/4a528effa127e1db82476eeb57c57649664af9b5
Cr-Commit-Position: refs/heads/master@{#419702}