Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2343433003:
Delete unused AddToHomescreenDialogHelper. (Closed)
DescriptionDelete unused AddToHomescreenDialogHelper.
This class was supposed to delete when AddToHomescreenManager was introduced
(https://codereview.chromium.org/2292133003/), but wasn't. Delete it now.
Committed: https://crrev.com/a876b44a5c8e58c710d0b8240db72fa5066a5747
Cr-Commit-Position: refs/heads/master@{#418726}
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
Description was changed from ========== Delete unused AddToHomescreenDialogHelper. ========== to ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced, but didn't. Remove them now. ==========
Description was changed from ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced, but didn't. Remove them now. ========== to ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced, but didn't. Remove them now. ==========
Description was changed from ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced, but didn't. Remove them now. ========== to ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced, but didn't. Delete it now. ==========
Description was changed from ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced, but didn't. Delete it now. ========== to ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced, but wasn't. Delete it now. ==========
hanxi@chromium.org changed reviewers: + pkotwicz@chromium.org
Hi Peter, could you please take a look? Thanks.
The CQ bit was checked by pkotwicz@chromium.org
lgtm
The CQ bit was unchecked by pkotwicz@chromium.org
pkotwicz@chromium.org changed reviewers: + dfalcantara@chromium.org
dfalcantara@ for OWNERS
Description was changed from ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced, but wasn't. Delete it now. ========== to ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced (https://codereview.chromium.org/2292133003/),but wasn't. Delete it now. ==========
Description was changed from ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced (https://codereview.chromium.org/2292133003/),but wasn't. Delete it now. ========== to ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced (https://codereview.chromium.org/2292133003/), but wasn't. Delete it now. ==========
lgtm
The CQ bit was checked by hanxi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced (https://codereview.chromium.org/2292133003/), but wasn't. Delete it now. ========== to ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced (https://codereview.chromium.org/2292133003/), but wasn't. Delete it now. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced (https://codereview.chromium.org/2292133003/), but wasn't. Delete it now. ========== to ========== Delete unused AddToHomescreenDialogHelper. This class was supposed to delete when AddToHomescreenManager was introduced (https://codereview.chromium.org/2292133003/), but wasn't. Delete it now. Committed: https://crrev.com/a876b44a5c8e58c710d0b8240db72fa5066a5747 Cr-Commit-Position: refs/heads/master@{#418726} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a876b44a5c8e58c710d0b8240db72fa5066a5747 Cr-Commit-Position: refs/heads/master@{#418726} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
