Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2343413004: [css-flexbox] Have to call updateBlockChildDirtyBitsBeforeLayout before layoutIfNeeded (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Have to call updateBlockChildDirtyBitsBeforeLayout before layoutIfNeeded This makes sure that we relayout children when necessary if they use a percentage height. BUG=527039 R=eae@chromium.org,dgrogan@chromium.org Committed: https://crrev.com/443873aad1beed753a2370a31079d51459e3c3a0 Cr-Commit-Position: refs/heads/master@{#420032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/bug527039.html View 1 chunk +66 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
cbiesinger
4 years, 3 months ago (2016-09-20 19:08:29 UTC) #1
eae
lgtm
4 years, 3 months ago (2016-09-21 11:30:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343413004/1
4 years, 3 months ago (2016-09-21 11:30:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 12:53:35 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 12:55:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/443873aad1beed753a2370a31079d51459e3c3a0
Cr-Commit-Position: refs/heads/master@{#420032}

Powered by Google App Engine
This is Rietveld 408576698