Issue 23434008: Array "splice" changeRecords should be emitted after the performChange has completed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23434008: Array "splice" changeRecords should be emitted after the performChange has completed (Closed)

Created:
7 years, 3 months ago by rafaelw

Modified:
7 years, 3 months ago

Reviewers:
rossberg

CC:
v8-dev, arv (Not doing code reviews), adamk

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Array "splice" changeRecords should be emitted after the performChange has completed (per spec) R=rossberg@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=16704

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -8 lines)			Patch
	M	src/array.js	View		6 chunks	+4 lines, -8 lines	0 comments	Download
	M	test/mjsunit/harmony/object-observe.js	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

rossberg

On 2013/09/11 10:54:19, rossberg wrote: > LGTM, landing. Actually, I take that back. :) We ...

7 years, 3 months ago (2013-09-11 10:55:30 UTC) #3

rossberg

7 years, 3 months ago (2013-09-13 08:13:10 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r16704 (presubmit successful).