Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4474)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java

Issue 2343383002: Draw downloads empty view more efficiently (Closed)
Patch Set: make it not crash on K Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/download_content.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
index 0e2041281e89ac84f5c09ce78384bb26f98f4f44..c605a163a734b4a606d5205469a216b95f46a255 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
@@ -11,6 +11,7 @@ import android.content.res.Resources;
import android.net.Uri;
import android.os.AsyncTask;
import android.os.StrictMode;
+import android.support.graphics.drawable.VectorDrawableCompat;
import android.support.v4.view.GravityCompat;
import android.support.v4.widget.DrawerLayout;
import android.support.v4.widget.DrawerLayout.DrawerListener;
@@ -25,6 +26,7 @@ import android.view.MenuItem;
import android.view.View;
import android.view.ViewGroup;
import android.widget.ListView;
+import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.ContentUriUtils;
@@ -137,7 +139,7 @@ public class DownloadManagerUi implements OnMenuItemClickListener {
private final SpaceDisplay mSpaceDisplay;
private final ListView mFilterView;
private final RecyclerView mRecyclerView;
- private final View mEmptyView;
+ private final TextView mEmptyView;
private final LoadingView mLoadingView;
private BasicNativePage mNativePage;
@@ -167,7 +169,10 @@ public class DownloadManagerUi implements OnMenuItemClickListener {
mMainView = (ViewGroup) LayoutInflater.from(activity).inflate(R.layout.download_main, null);
- mEmptyView = mMainView.findViewById(R.id.empty_view);
+ mEmptyView = (TextView) mMainView.findViewById(R.id.empty_view);
+ mEmptyView.setCompoundDrawablesWithIntrinsicBounds(null, VectorDrawableCompat
+ .create(activity.getResources(), R.drawable.downloads_big, activity.getTheme()),
+ null, null);
mLoadingView = (LoadingView) mMainView.findViewById(R.id.loading_view);
mLoadingView.showLoadingUI();
« no previous file with comments | « chrome/android/java/res/layout/download_content.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698