Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2343373002: Re-enable more geolocation browser tests. (Closed)

Created:
4 years, 3 months ago by dominickn
Modified:
4 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable more geolocation browser tests. BUG=523387 Committed: https://crrev.com/791af6c9867897eb08f82e935abf845559acb9ae Cr-Commit-Position: refs/heads/master@{#419424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/geolocation/geolocation_browsertest.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dominickn
Hi Michael, WDYT? Again, these don't seem to flake when run through the linux, win, ...
4 years, 3 months ago (2016-09-19 02:37:59 UTC) #6
Michael van Ouwerkerk
lgtm
4 years, 3 months ago (2016-09-19 09:54:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343373002/1
4 years, 3 months ago (2016-09-19 10:01:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 10:05:49 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 10:07:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/791af6c9867897eb08f82e935abf845559acb9ae
Cr-Commit-Position: refs/heads/master@{#419424}

Powered by Google App Engine
This is Rietveld 408576698