Prune CreateVisiblePositionDeprecated from DragCaretController

Prune CreateVisiblePositionDeprecated from DragCaretController

DragCaretController::setCaretPosition is called either with a null
position (from DragCaretController::clear), or after a hit test.
In either case, we don't need to update layout before creating a
VisiblePosition from the passed Position.

BUG=647219
Committed: https://crrev.com/88a3c048159bb78cb16a46327e837029f9a3d580
Cr-Commit-Position: refs/heads/master@{#419693}

[Xiaocheng, 2016-09-20 02:58:33]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 02:58:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-20 03:01:02]

Description was changed from

==========
Prune CreateVisiblePositionDeprecated from DragCaretController

BUG=647219
==========

to

==========
Prune CreateVisiblePositionDeprecated from DragCaretController

DragCaretController::setCaretPosition is called either with a null
position (from DragCaretController::clear), or after a hit test.
In either case, we don't need to update layout before creating a
VisiblePosition from the passed Position.

BUG=647219
==========

[Xiaocheng, 2016-09-20 03:43:25]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-09-20 03:43:26]

PTAL.

[commit-bot: I haz the power, 2016-09-20 04:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 04:13:49]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-09-20 07:45:59]

lgtm
Thanks!

https://codereview.chromium.org/2343363006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/DragCaretController.cpp (right):

https://codereview.chromium.org/2343363006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/DragCaretController.cpp:72: m_position =
createVisiblePosition(position);
Note: Since we call |DragCaretController::setCaretPosition()| with dirty layout
tree, |createVisiblePosition()| hits |DCHECK()|, this rewrite is safe.

[yosin_UTC9, 2016-09-20 07:46:04]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-09-20 07:46:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-20 07:53:52]

On 2016/09/20 at 07:45:59, yosin wrote:
> lgtm
> Thanks!
> 
>
https://codereview.chromium.org/2343363006/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/DragCaretController.cpp (right):
> 
>
https://codereview.chromium.org/2343363006/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/DragCaretController.cpp:72: m_position
= createVisiblePosition(position);
> Note: Since we call |DragCaretController::setCaretPosition()| with dirty
layout tree, |createVisiblePosition()| hits |DCHECK()|, this rewrite is safe.

Sorry I don't understand...

When called with dirty layout tree, |position| must be null, in which case we do
not even reach the DCHECK in VP::create().

[commit-bot: I haz the power, 2016-09-20 08:10:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 08:11:49]

Description was changed from

==========
Prune CreateVisiblePositionDeprecated from DragCaretController

DragCaretController::setCaretPosition is called either with a null
position (from DragCaretController::clear), or after a hit test.
In either case, we don't need to update layout before creating a
VisiblePosition from the passed Position.

BUG=647219
==========

to

==========
Prune CreateVisiblePositionDeprecated from DragCaretController

DragCaretController::setCaretPosition is called either with a null
position (from DragCaretController::clear), or after a hit test.
In either case, we don't need to update layout before creating a
VisiblePosition from the passed Position.

BUG=647219

Committed: https://crrev.com/88a3c048159bb78cb16a46327e837029f9a3d580
Cr-Commit-Position: refs/heads/master@{#419693}
==========

[commit-bot: I haz the power, 2016-09-20 08:11:50]

Patchset 1 (id:??) landed as
https://crrev.com/88a3c048159bb78cb16a46327e837029f9a3d580
Cr-Commit-Position: refs/heads/master@{#419693}