Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2343343002: Revert of Evacuate ComputedStyle references from the CSS*Value hierarchy (Closed)

Created:
4 years, 3 months ago by Avi (use Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Timothy Loh, sashab, fs
CC:
ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, Justin Novosad, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Evacuate ComputedStyle references from the CSS*Value hierarchy (patchset #1 id:1 of https://codereview.chromium.org/2345893004/ ) Reason for revert: Tree is red; this patch fails to compile: ../../third_party/WebKit/Source/core/css/CSSValuePair.h:42:12: error: incomplete result type 'WTF::String' in function definition String customCSSText() const Original issue's description: > Evacuate ComputedStyle references from the CSS*Value hierarchy > > Fold uses of: > > CSSPrimitiveValue::create(..., const ComputedStyle&) > CSSValuePair::create(..., const ComputedStyle&) > > into the (few) users. Handle the fall-out. > > Committed: https://crrev.com/ba9df880383908b052d5a7d00abb32deec94cfc5 > Cr-Commit-Position: refs/heads/master@{#419382} TBR=sashab@chromium.org,timloh@chromium.org,fs@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/533dcff13b0b002494a3040d2f90de937a93e76d Cr-Commit-Position: refs/heads/master@{#419385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -50 lines) Patch
M third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp View 2 chunks +15 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.h View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValuePair.h View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValuePool.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 5 chunks +26 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasFontCache.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Avi (use Gerrit)
Created Revert of Evacuate ComputedStyle references from the CSS*Value hierarchy
4 years, 3 months ago (2016-09-17 20:43:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343343002/1
4 years, 3 months ago (2016-09-17 20:44:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-17 20:44:53 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 20:46:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/533dcff13b0b002494a3040d2f90de937a93e76d
Cr-Commit-Position: refs/heads/master@{#419385}

Powered by Google App Engine
This is Rietveld 408576698