Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2343263002: Flesh out GN/Android run docs. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
csmartdalton
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Flesh out GN/Android run docs. The process is simple enough that it's clearer to see all the steps laid out. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343263002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2343263002 Committed: https://skia.googlesource.com/skia/+/e7904f3979e2e8b80b5d77165291e649ff1278dd

Patch Set 1 #

Patch Set 2 : editing #

Patch Set 3 : punctuation #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M site/user/quick/gn.md View 1 2 1 chunk +5 lines, -2 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
mtklein_C
4 years, 3 months ago (2016-09-16 19:14:40 UTC) #3
csmartdalton
https://codereview.chromium.org/2343263002/diff/40001/site/user/quick/gn.md File site/user/quick/gn.md (right): https://codereview.chromium.org/2343263002/diff/40001/site/user/quick/gn.md#newcode91 site/user/quick/gn.md:91: adb push resources /data/local/tmp Resources are specific to the ...
4 years, 3 months ago (2016-09-16 19:25:09 UTC) #4
mtklein_C
https://codereview.chromium.org/2343263002/diff/40001/site/user/quick/gn.md File site/user/quick/gn.md (right): https://codereview.chromium.org/2343263002/diff/40001/site/user/quick/gn.md#newcode91 site/user/quick/gn.md:91: adb push resources /data/local/tmp On 2016/09/16 at 19:25:09, csmartdalton ...
4 years, 3 months ago (2016-09-16 19:30:56 UTC) #5
csmartdalton
Fair enough, failing instructions are worse. lgtm
4 years, 3 months ago (2016-09-16 19:34:01 UTC) #6
csmartdalton
Fair enough, failing instructions are worse. lgtm
4 years, 3 months ago (2016-09-16 19:34:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343263002/40001
4 years, 3 months ago (2016-09-16 19:39:22 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:40:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e7904f3979e2e8b80b5d77165291e649ff1278dd

Powered by Google App Engine
This is Rietveld 408576698