Make WebSocket.fromSocket public.

sdk/lib/io/websocket.dart

Index: sdk/lib/io/websocket.dart
diff --git a/sdk/lib/io/websocket.dart b/sdk/lib/io/websocket.dart
index 32dc9e065ea13c36c1a62fa3af7891edd9cc7d1a..9d241254bf88656e312949c18273206590235848 100644
--- a/sdk/lib/io/websocket.dart
+++ b/sdk/lib/io/websocket.dart
@@ -134,6 +134,25 @@ abstract class WebSocket implements Stream, StreamSink {
       _WebSocketImpl.connect(url, protocols);
 
   /**
+   * Creates a WebSocket from an already-upgraded socket.
+   *
+   * The initial WebSocket handshake must have occurred prior to this call. A
+   * WebSocket client can automatically perform the handshake using
+   * [WebSocket.connect], while a server can do so using
+   * [WebSocketTransformer.upgrade]. To manually upgrade an [HttpRequest],
+   * [HttpRequest.detachSocket] may be called.
+   *
+   * [protocol] should be the protocol negotiated by this handshake, if any.
+   *
+   * If [serverSide] is `true`, the WebSocket will act as the server and mask
+   * the messages it sends. If it's `false`, it will act as the client and will

[Anders Johnsen, 2014/04/29 20:05:10]

It's the other way around :)

[nweiz, 2014/04/30 22:33:27]

Done.

+   * not mask its messages.
+   */
+  factory WebSocket.fromUpgradedSocket(Socket socket, {String protocol,
+        bool serverSide: true}) =>

[Anders Johnsen, 2014/04/29 20:05:10]

Maybe serverSide should be a mandatory argument? The user should always consider
what to use.

[nweiz, 2014/04/30 22:33:27]

It's good to encourage the user to consider, but I think that's outweighed by
the benefit when reading the code of seeing the name of the parameter. Unnamed
boolean parameters are difficult to understand when reading code.

[Anders Johnsen, 2014/05/01 04:58:12]

That is a good argument - I sometimes forget the caller benefits of names
optional arguments.

+      new _WebSocketImpl._fromSocket(socket, protocol, serverSide);
+
+  /**
    * Returns the current state of the connection.
    */
   int get readyState;