Make WebSocket.fromSocket public.

sdk/lib/io/websocket.dart

Index: sdk/lib/io/websocket.dart
diff --git a/sdk/lib/io/websocket.dart b/sdk/lib/io/websocket.dart
index 32dc9e065ea13c36c1a62fa3af7891edd9cc7d1a..3269119d9cb7f830611b33200cc7929b014b72b1 100644
--- a/sdk/lib/io/websocket.dart
+++ b/sdk/lib/io/websocket.dart
@@ -134,6 +134,17 @@ abstract class WebSocket implements Stream, StreamSink {
       _WebSocketImpl.connect(url, protocols);
 
   /**
+   * Creates a WebSocket from an existing socket.

[Anders Johnsen, 2014/04/29 10:43:44]

[...] an already upgraded socket.

[nweiz, 2014/04/29 19:56:39]

Done.

+   *
+   * The initial WebSocket handshake must have occurred prior to this call.

[Anders Johnsen, 2014/04/29 10:43:44]

This comment should be expanded to include references to:

  WebSocket.connect

and
  
  WebSocketTransformer.upgrade & HttpResponse.detachSocket

To be sure we point people to where a upgraded socket is easily created from.

[nweiz, 2014/04/29 19:56:39]

Done.

+   * [protocol] should be the protocol negotiated by this handshake, if any.

[Anders Johnsen, 2014/04/29 10:43:44]

protocol and serverSide should be in separate paragraphs. Mention what happens
if serverSide is either true or false (e.g. frame masking is performed in the
direction of client->server).

[nweiz, 2014/04/29 19:56:39]

Done.

+   * [serverSide] indicates whether this is a server socket or a client socket.
+   */
+  factory WebSocket.fromSocket(Socket socket, {String protocol,

[Anders Johnsen, 2014/04/29 10:43:44]

Please change the name to something along the lines of:

  WebSocket.fromUpgradedSocket
  WebSocket.fromDetachedSocket

or something else.

fromSocket is too generic, and the user may be tempted to do:

Socket.connect(...).then((socket) => new WebSocket.fromSocket(socket))

which will not work.

[nweiz, 2014/04/29 19:56:39]

Done.

+        bool serverSide: true}) =>
+      new _WebSocketImpl._fromSocket(socket, protocol, serverSide);
+
+  /**
    * Returns the current state of the connection.
    */
   int get readyState;