Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2343213002: chromeos: Avoid EasyUnlockGetKeysOperation D-Bus log spam. (Closed)

Created:
4 years, 3 months ago by Daniel Erat
Modified:
4 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Avoid EasyUnlockGetKeysOperation D-Bus log spam. Make EasyUnlockGetKeysOperation wait for the cryptohome D-Bus service to be available before making a GetKeyDataEx method call to it. Otherwise, we get repeated log spam at boot: [1912:1912:0916/102203:ERROR:object_proxy.cc(583)] Failed to call method: org.chromium.CryptohomeInterface.GetKeyDataEx: object_path= /org/chromium/Cryptohome: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.Cryptohome was not provided by any .service files [1912:1912:0916/102203:ERROR:easy_unlock_get_keys_operation.cc(61)] Easy unlock failed to get key data, code=1 BUG=636554 Committed: https://crrev.com/e704807ee8bdb5829fb147f59b74e3a218f4de04 Cr-Commit-Position: refs/heads/master@{#419228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc View 3 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Daniel Erat
4 years, 3 months ago (2016-09-16 17:54:11 UTC) #3
xiyuan
lgtm Thanks for the documentation.
4 years, 3 months ago (2016-09-16 17:57:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343213002/1
4 years, 3 months ago (2016-09-16 18:13:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 18:39:00 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 18:40:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e704807ee8bdb5829fb147f59b74e3a218f4de04
Cr-Commit-Position: refs/heads/master@{#419228}

Powered by Google App Engine
This is Rietveld 408576698