Issue 23432007: Close Views collected cookies dialog on interstitial WebUI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23432007: Close Views collected cookies dialog on interstitial WebUI (Closed)

Created:
7 years, 3 months ago by Mike Wittman

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Close Views collected cookies dialog on interstitial WebUI Configure the collected cookies dialog to be closed when interstital WebUI is displayed (e.g. for SSL warnings prior to page load). BUG=240575 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221792

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/ui/views/collected_cookies_views.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Mike Wittman

Hi Scott, PTAL. This builds on https://codereview.chromium.org/23981002. I'll be sending several close-on-interstitial-webui reviews, each for ...

7 years, 3 months ago (2013-09-05 20:36:18 UTC) #1

Mike Wittman

7 years, 3 months ago (2013-09-06 22:12:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r221792 (presubmit successful).