components/autofill/core/common/autofill_messages.h - Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/autofill_messages.h

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address llya's nits and fix a bug in form structure unit test. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_generation_manager.cc ('K') | « components/autofill/core/browser/test_autofill_manager_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/autofill_messages.h

diff --git a/components/autofill/core/common/autofill_messages.h b/components/autofill/core/common/autofill_messages.h

index b17ae64c77135216c05d5730002fb9ec908bc2b6..2497394c0428fbbf7a2b602ab12f478ef79e6c3e 100644

--- a/components/autofill/core/common/autofill_messages.h

+++ b/components/autofill/core/common/autofill_messages.h

@@ -22,7 +22,6 @@

#include "ipc/ipc_message_utils.h"

#include "third_party/WebKit/public/web/WebFormElement.h"

#include "ui/gfx/rect.h"

-#include "url/gurl.h"

#define IPC_MESSAGE_START AutofillMsgStart

@@ -190,6 +189,11 @@ IPC_MESSAGE_ROUTED0(AutofillMsg_AutocheckoutSupported)

// after being preloaded.

IPC_MESSAGE_ROUTED0(AutofillMsg_PageShown)

+// Sent when Autofill manager gets the query response from the Autofill server

+// and there are fields classified as ACCOUNT_CREATION_PASSWORD in the response.

+IPC_MESSAGE_ROUTED1(AutofillMsg_AccountCreationFormsDetected,

+ std::vector<autofill::FormData> /* forms */)

// Autofill messages sent from the renderer to the browser.

// TODO(creis): check in the browser that the renderer actually has permission