components/autofill/core/browser/autofill_manager_delegate.h - Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager_delegate.h

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address llya's nits and fix a bug in form structure unit test. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_generation_manager.cc ('K') | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/autofill_profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager_delegate.h

diff --git a/components/autofill/core/browser/autofill_manager_delegate.h b/components/autofill/core/browser/autofill_manager_delegate.h

index 374c105fd5dce8fd96a5d973e1e59953fcba6259..0cea2135d9b1b3fd39b958d8ec59e19eed1a3f93 100644

--- a/components/autofill/core/browser/autofill_manager_delegate.h

+++ b/components/autofill/core/browser/autofill_manager_delegate.h

@@ -142,6 +142,11 @@ class AutofillManagerDelegate {

virtual void UpdateAutocheckoutStep(

AutocheckoutStepType step_type,

AutocheckoutStepStatus step_status) = 0;

+ // Pass the form structures to the password generation manager to detect

+ // account creation forms.

+ virtual void DetectAccountCreationForms(

+ const std::vector<autofill::FormStructure*>& forms) = 0;

};

} // namespace autofill