chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc - Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address llya's nits and fix a bug in form structure unit test. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/tab_autofill_manager_delegate.h ('k') | components/autofill/content/renderer/password_generation_manager.h » ('j') | components/autofill/content/renderer/password_generation_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

index 4b5094903ca815ca029ee36dc7c6bd85cb749490..f8ef15e465b247a0883597df8410cc3082c78521 100644

--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/autofill/autofill_cc_infobar_delegate.h"

#include "chrome/browser/autofill/personal_data_manager_factory.h"

#include "chrome/browser/infobars/infobar_service.h"

+#include "chrome/browser/password_manager/password_generation_manager.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/autofill/autocheckout_bubble.h"

#include "chrome/browser/ui/autofill/autocheckout_bubble_controller.h"

@@ -257,4 +258,12 @@ void TabAutofillManagerDelegate::WebContentsDestroyed(

HideAutofillPopup();

}

+void TabAutofillManagerDelegate::DetectAccountCreationForms(

+ const std::vector<autofill::FormStructure*>& forms) {

+ PasswordGenerationManager* manager =

+ PasswordGenerationManager::FromWebContents(web_contents_);

+ if (manager)

+ manager->DetectAccountCreationForms(forms);

} // namespace autofill