Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/password_manager/password_generation_manager.cc

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_generation_manager.cc
diff --git a/chrome/browser/password_manager/password_generation_manager.cc b/chrome/browser/password_manager/password_generation_manager.cc
index e53f61a7b682589a664f9ab33aa35e8a7133edcd..7db7936c1b42e3630269eb8c865608dbaf01bfae 100644
--- a/chrome/browser/password_manager/password_generation_manager.cc
+++ b/chrome/browser/password_manager/password_generation_manager.cc
@@ -13,8 +13,12 @@
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/common/pref_names.h"
+#include "components/autofill/core/browser/autofill_field.h"
+#include "components/autofill/core/browser/field_types.h"
+#include "components/autofill/core/browser/form_structure.h"
#include "components/autofill/core/browser/password_generator.h"
#include "components/autofill/core/common/autofill_messages.h"
+#include "components/autofill/core/common/form_data.h"
#include "components/user_prefs/pref_registry_syncable.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_view_host.h"
@@ -55,6 +59,25 @@ void PasswordGenerationManager::RegisterProfilePrefs(
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
}
+void PasswordGenerationManager::DetectAccountCreationForms(
+ const std::vector<autofill::FormStructure*>& forms) {
+ std::vector<autofill::FormData> account_creation_forms;
+ for (std::vector<autofill::FormStructure*>::const_iterator form_it =
+ forms.begin(); form_it != forms.end(); ++form_it) {
+ autofill::FormStructure* form = *form_it;
+ for (std::vector<autofill::AutofillField*>::const_iterator field_it =
+ form->begin(); field_it != form->end(); ++field_it) {
+ autofill::AutofillField* field = *field_it;
+ if (field->server_type() == autofill::ACCOUNT_CREATION_PASSWORD) {
+ account_creation_forms.push_back(form->ToFormData());
+ break;
+ }
+ }
+ }
+ SendAccountCreationFormsToRenderer(web_contents()->GetRenderViewHost(),
+ account_creation_forms);
+}
+
void PasswordGenerationManager::RegisterWithSyncService() {
Profile* profile = Profile::FromBrowserContext(
web_contents()->GetBrowserContext());
@@ -151,6 +174,13 @@ void PasswordGenerationManager::SendStateToRenderer(
enabled));
}
+void PasswordGenerationManager::SendAccountCreationFormsToRenderer(
+ content::RenderViewHost* host,
+ const std::vector<autofill::FormData>& forms) {
+ host->Send(new AutofillMsg_AccountCreationFormsDetected(
+ host->GetRoutingID(), forms));
+}
+
void PasswordGenerationManager::OnShowPasswordGenerationPopup(
const gfx::Rect& bounds,
int max_length,

Powered by Google App Engine
This is Rietveld 408576698