Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.h

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address llya's nits and fix a bug in form structure unit test. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_AUTOFILL_TAB_AUTOFILL_MANAGER_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_UI_AUTOFILL_TAB_AUTOFILL_MANAGER_DELEGATE_H_
6 #define CHROME_BROWSER_UI_AUTOFILL_TAB_AUTOFILL_MANAGER_DELEGATE_H_ 6 #define CHROME_BROWSER_UI_AUTOFILL_TAB_AUTOFILL_MANAGER_DELEGATE_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/i18n/rtl.h" 10 #include "base/i18n/rtl.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 const std::vector<base::string16>& values, 76 const std::vector<base::string16>& values,
77 const std::vector<base::string16>& labels) OVERRIDE; 77 const std::vector<base::string16>& labels) OVERRIDE;
78 virtual void HideAutofillPopup() OVERRIDE; 78 virtual void HideAutofillPopup() OVERRIDE;
79 virtual bool IsAutocompleteEnabled() OVERRIDE; 79 virtual bool IsAutocompleteEnabled() OVERRIDE;
80 80
81 virtual void AddAutocheckoutStep(AutocheckoutStepType step_type) OVERRIDE; 81 virtual void AddAutocheckoutStep(AutocheckoutStepType step_type) OVERRIDE;
82 virtual void UpdateAutocheckoutStep( 82 virtual void UpdateAutocheckoutStep(
83 AutocheckoutStepType step_type, 83 AutocheckoutStepType step_type,
84 AutocheckoutStepStatus step_status) OVERRIDE; 84 AutocheckoutStepStatus step_status) OVERRIDE;
85 85
86 virtual void DetectAccountCreationForms(
87 const std::vector<autofill::FormStructure*>& forms) OVERRIDE;
88
86 // content::WebContentsObserver implementation. 89 // content::WebContentsObserver implementation.
87 virtual void DidNavigateMainFrame( 90 virtual void DidNavigateMainFrame(
88 const content::LoadCommittedDetails& details, 91 const content::LoadCommittedDetails& details,
89 const content::FrameNavigateParams& params) OVERRIDE; 92 const content::FrameNavigateParams& params) OVERRIDE;
90 virtual void WebContentsDestroyed( 93 virtual void WebContentsDestroyed(
91 content::WebContents* web_contents) OVERRIDE; 94 content::WebContents* web_contents) OVERRIDE;
92 virtual void WasShown() OVERRIDE; 95 virtual void WasShown() OVERRIDE;
93 96
94 // Exposed for testing. 97 // Exposed for testing.
95 AutofillDialogController* GetDialogControllerForTesting() { 98 AutofillDialogController* GetDialogControllerForTesting() {
96 return dialog_controller_.get(); 99 return dialog_controller_.get();
97 } 100 }
98 101
99 private: 102 private:
100 explicit TabAutofillManagerDelegate(content::WebContents* web_contents); 103 explicit TabAutofillManagerDelegate(content::WebContents* web_contents);
101 friend class content::WebContentsUserData<TabAutofillManagerDelegate>; 104 friend class content::WebContentsUserData<TabAutofillManagerDelegate>;
102 105
103 content::WebContents* const web_contents_; 106 content::WebContents* const web_contents_;
104 base::WeakPtr<AutofillDialogController> dialog_controller_; 107 base::WeakPtr<AutofillDialogController> dialog_controller_;
105 base::WeakPtr<AutocheckoutBubble> autocheckout_bubble_; 108 base::WeakPtr<AutocheckoutBubble> autocheckout_bubble_;
106 base::WeakPtr<AutofillPopupControllerImpl> popup_controller_; 109 base::WeakPtr<AutofillPopupControllerImpl> popup_controller_;
107 110
108 DISALLOW_COPY_AND_ASSIGN(TabAutofillManagerDelegate); 111 DISALLOW_COPY_AND_ASSIGN(TabAutofillManagerDelegate);
109 }; 112 };
110 113
111 } // namespace autofill 114 } // namespace autofill
112 115
113 #endif // CHROME_BROWSER_UI_AUTOFILL_TAB_AUTOFILL_MANAGER_DELEGATE_H_ 116 #endif // CHROME_BROWSER_UI_AUTOFILL_TAB_AUTOFILL_MANAGER_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698