Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Side by Side Diff: components/autofill/core/common/autofill_messages.h

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Multiply-included message file, hence no include guard. 5 // Multiply-included message file, hence no include guard.
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "components/autofill/core/common/autocheckout_status.h" 10 #include "components/autofill/core/common/autocheckout_status.h"
11 #include "components/autofill/core/common/form_data.h" 11 #include "components/autofill/core/common/form_data.h"
12 #include "components/autofill/core/common/form_data_predictions.h" 12 #include "components/autofill/core/common/form_data_predictions.h"
13 #include "components/autofill/core/common/form_field_data.h" 13 #include "components/autofill/core/common/form_field_data.h"
14 #include "components/autofill/core/common/form_field_data_predictions.h" 14 #include "components/autofill/core/common/form_field_data_predictions.h"
15 #include "components/autofill/core/common/forms_seen_state.h" 15 #include "components/autofill/core/common/forms_seen_state.h"
16 #include "components/autofill/core/common/password_form_fill_data.h" 16 #include "components/autofill/core/common/password_form_fill_data.h"
17 #include "components/autofill/core/common/web_element_descriptor.h" 17 #include "components/autofill/core/common/web_element_descriptor.h"
18 #include "content/public/common/common_param_traits.h" 18 #include "content/public/common/common_param_traits.h"
19 #include "content/public/common/common_param_traits_macros.h" 19 #include "content/public/common/common_param_traits_macros.h"
20 #include "content/public/common/password_form.h" 20 #include "content/public/common/password_form.h"
21 #include "ipc/ipc_message_macros.h" 21 #include "ipc/ipc_message_macros.h"
22 #include "ipc/ipc_message_utils.h" 22 #include "ipc/ipc_message_utils.h"
23 #include "third_party/WebKit/public/web/WebFormElement.h" 23 #include "third_party/WebKit/public/web/WebFormElement.h"
24 #include "ui/gfx/rect.h" 24 #include "ui/gfx/rect.h"
25 #include "url/gurl.h"
26 25
27 #define IPC_MESSAGE_START AutofillMsgStart 26 #define IPC_MESSAGE_START AutofillMsgStart
28 27
29 IPC_ENUM_TRAITS_MAX_VALUE(autofill::AutocheckoutStatus, 28 IPC_ENUM_TRAITS_MAX_VALUE(autofill::AutocheckoutStatus,
30 autofill::AUTOCHECKOUT_STATUS_NUM_STATUS - 1) 29 autofill::AUTOCHECKOUT_STATUS_NUM_STATUS - 1)
31 IPC_ENUM_TRAITS_MAX_VALUE(autofill::FormsSeenState, 30 IPC_ENUM_TRAITS_MAX_VALUE(autofill::FormsSeenState,
32 autofill::FORMS_SEEN_STATE_NUM_STATES - 1) 31 autofill::FORMS_SEEN_STATE_NUM_STATES - 1)
33 IPC_ENUM_TRAITS_MAX_VALUE(base::i18n::TextDirection, 32 IPC_ENUM_TRAITS_MAX_VALUE(base::i18n::TextDirection,
34 base::i18n::TEXT_DIRECTION_NUM_DIRECTIONS - 1) 33 base::i18n::TEXT_DIRECTION_NUM_DIRECTIONS - 1)
35 34
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 182
184 // Sent when Autocheckout is supported for the current page. The page has to 183 // Sent when Autocheckout is supported for the current page. The page has to
185 // be whitelisted and the Autofill server must have returned Autocheckout page 184 // be whitelisted and the Autofill server must have returned Autocheckout page
186 // metadata. 185 // metadata.
187 IPC_MESSAGE_ROUTED0(AutofillMsg_AutocheckoutSupported) 186 IPC_MESSAGE_ROUTED0(AutofillMsg_AutocheckoutSupported)
188 187
189 // Sent when the current page is actually displayed in the browser, possibly 188 // Sent when the current page is actually displayed in the browser, possibly
190 // after being preloaded. 189 // after being preloaded.
191 IPC_MESSAGE_ROUTED0(AutofillMsg_PageShown) 190 IPC_MESSAGE_ROUTED0(AutofillMsg_PageShown)
192 191
192 // Sent when autofill manager gets the query response from the autofill server
Ilya Sherman 2013/09/03 23:58:01 nit: "autofill" -> "Autofill"
zysxqn 2013/09/04 17:26:20 Done.
193 // and there are fields classified as ACCOUNT_CREATION_PASSWORD in the response.
194 IPC_MESSAGE_ROUTED1(AutofillMsg_AccountCreationFormsDetected,
195 std::vector<autofill::FormData> /* forms */)
196
193 // Autofill messages sent from the renderer to the browser. 197 // Autofill messages sent from the renderer to the browser.
194 198
195 // TODO(creis): check in the browser that the renderer actually has permission 199 // TODO(creis): check in the browser that the renderer actually has permission
196 // for the URL to avoid compromised renderers talking to the browser. 200 // for the URL to avoid compromised renderers talking to the browser.
197 201
198 // Notification that forms have been seen that are candidates for 202 // Notification that forms have been seen that are candidates for
199 // filling/submitting by the AutofillManager. 203 // filling/submitting by the AutofillManager.
200 IPC_MESSAGE_ROUTED3(AutofillHostMsg_FormsSeen, 204 IPC_MESSAGE_ROUTED3(AutofillHostMsg_FormsSeen,
201 std::vector<autofill::FormData> /* forms */, 205 std::vector<autofill::FormData> /* forms */,
202 base::TimeTicks /* timestamp */, 206 base::TimeTicks /* timestamp */,
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions, 296 IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,
293 autofill::FormFieldData /* the form field */, 297 autofill::FormFieldData /* the form field */,
294 gfx::RectF /* input field bounds, window-relative */, 298 gfx::RectF /* input field bounds, window-relative */,
295 std::vector<base::string16> /* suggestions */, 299 std::vector<base::string16> /* suggestions */,
296 std::vector<base::string16> /* realms */) 300 std::vector<base::string16> /* realms */)
297 301
298 // Inform browser of data list values for the curent field. 302 // Inform browser of data list values for the curent field.
299 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList, 303 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
300 std::vector<base::string16> /* values */, 304 std::vector<base::string16> /* values */,
301 std::vector<base::string16> /* labels */) 305 std::vector<base::string16> /* labels */)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698