Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/autofill/tab_autofill_manager_delegate.h" 5 #include "chrome/browser/ui/autofill/tab_autofill_manager_delegate.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/browser/autofill/autocheckout_whitelist_manager_factory.h" 9 #include "chrome/browser/autofill/autocheckout_whitelist_manager_factory.h"
10 #include "chrome/browser/autofill/autofill_cc_infobar_delegate.h" 10 #include "chrome/browser/autofill/autofill_cc_infobar_delegate.h"
11 #include "chrome/browser/autofill/personal_data_manager_factory.h" 11 #include "chrome/browser/autofill/personal_data_manager_factory.h"
12 #include "chrome/browser/infobars/infobar_service.h" 12 #include "chrome/browser/infobars/infobar_service.h"
13 #include "chrome/browser/password_manager/password_generation_manager.h"
13 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/ui/autofill/autocheckout_bubble.h" 15 #include "chrome/browser/ui/autofill/autocheckout_bubble.h"
15 #include "chrome/browser/ui/autofill/autocheckout_bubble_controller.h" 16 #include "chrome/browser/ui/autofill/autocheckout_bubble_controller.h"
16 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h" 17 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
17 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h" 18 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
18 #include "chrome/browser/ui/browser.h" 19 #include "chrome/browser/ui/browser.h"
19 #include "chrome/browser/ui/browser_finder.h" 20 #include "chrome/browser/ui/browser_finder.h"
20 #include "chrome/browser/ui/browser_window.h" 21 #include "chrome/browser/ui/browser_window.h"
21 #include "chrome/browser/ui/chrome_pages.h" 22 #include "chrome/browser/ui/chrome_pages.h"
22 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h" 23 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 (!was_redirect && !preserve_dialog)) { 251 (!was_redirect && !preserve_dialog)) {
251 HideRequestAutocompleteDialog(); 252 HideRequestAutocompleteDialog();
252 } 253 }
253 } 254 }
254 255
255 void TabAutofillManagerDelegate::WebContentsDestroyed( 256 void TabAutofillManagerDelegate::WebContentsDestroyed(
256 content::WebContents* web_contents) { 257 content::WebContents* web_contents) {
257 HideAutofillPopup(); 258 HideAutofillPopup();
258 } 259 }
259 260
261 void TabAutofillManagerDelegate::DetectAccountCreationForms(
262 const std::vector<autofill::FormStructure*>& forms) {
263 PasswordGenerationManager* manager =
264 PasswordGenerationManager::FromWebContents(web_contents_);
265 if (manager) {
266 manager->DetectAccountCreationForms(forms);
267 }
Ilya Sherman 2013/09/03 23:58:01 nit: No need for curly braces.
zysxqn 2013/09/04 17:26:20 Done.
268 }
269
260 } // namespace autofill 270 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698