Generate passwords only for forms that autofill server marks as account creation forms.

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
 #include <set>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/guid.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/sequenced_worker_pool.h"
+#include "chrome/browser/password_manager/password_generation_manager.h"
 #include "components/autofill/content/browser/autocheckout/whitelist_manager.h"
 #include "components/autofill/content/browser/autocheckout_manager.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_data_model.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/autofill_manager_delegate.h"
 #include "components/autofill/core/browser/autofill_manager_test_delegate.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
@@ skipping 704 matching lines @@
     const std::string& response_xml) {
   scoped_ptr<autofill::AutocheckoutPageMetaData> page_meta_data(
       new autofill::AutocheckoutPageMetaData());
 
   // Parse and store the server predictions.
   FormStructure::ParseQueryResponse(response_xml,
                                     form_structures_.get(),
                                     page_meta_data.get(),
                                     *metric_logger_);
 
+  // Forward form structures to the password generation manager to detect
+  // account creation form.
+  PasswordGenerationManager* manager =
+      PasswordGenerationManager::FromWebContents(driver_->GetWebContents());
+  if (manager) {
+    manager->DetectAccountCreationForms(form_structures_.get());
+  }

[Ilya Sherman, 2013/08/29 23:08:13]

nit: No need for curly braces.

[zysxqn, 2013/09/03 23:00:20]

NA now.

+
   if (page_meta_data->IsInAutofillableFlow()) {
     RenderViewHost* host = driver_->GetWebContents()->GetRenderViewHost();
     if (host)
       host->Send(new AutofillMsg_AutocheckoutSupported(host->GetRoutingID()));
   }
 
   // TODO(ahutter): Remove this once Autocheckout is implemented on other
   // platforms. See http://crbug.com/173416.
 #if defined(TOOLKIT_VIEWS)
   if (!GetAutocheckoutURLPrefix().empty())
@@ skipping 453 matching lines @@
 
 void AutofillManager::UpdateInitialInteractionTimestamp(
     const TimeTicks& interaction_timestamp) {
   if (initial_interaction_timestamp_.is_null() ||
       interaction_timestamp < initial_interaction_timestamp_) {
     initial_interaction_timestamp_ = interaction_timestamp;
   }
 }
 
 }  // namespace autofill