Generate passwords only for forms that autofill server marks as account creation forms.

chrome/browser/password_manager/password_generation_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_generation_manager.h"
 
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/password_manager/password_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/common/pref_names.h"
+#include "components/autofill/core/browser/autofill_field.h"
+#include "components/autofill/core/browser/field_types.h"
+#include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/browser/password_generator.h"
 #include "components/autofill/core/common/autofill_messages.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/password_form.h"
 #include "ipc/ipc_message_macros.h"
 #include "ui/gfx/rect.h"
 
@@ skipping 22 matching lines @@
 
 // static
 void PasswordGenerationManager::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterBooleanPref(
       prefs::kPasswordGenerationEnabled,
       true,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 }
 
+void PasswordGenerationManager::DetectAccountCreationForms(
+    const std::vector<autofill::FormStructure*>& forms) {
+  std::vector<GURL> account_creation_form_origins;
+  for (std::vector<autofill::FormStructure*>::const_iterator form_it =
+      forms.begin(); form_it != forms.end(); ++form_it) {
+    autofill::FormStructure* form = *form_it;
+    for (std::vector<autofill::AutofillField*>::const_iterator field_it =
+        form->begin(); field_it != form->end(); ++field_it) {

[Ilya Sherman, 2013/08/29 23:08:13]

nit: Indent this line 5 more spaces.

[zysxqn, 2013/09/03 23:00:20]

Done.

+      autofill::AutofillField* field = *field_it;
+      if (field->server_type() == autofill::ACCOUNT_CREATION_PASSWORD) {
+        account_creation_form_origins.push_back(form->source_url());

[Garrett Casto, 2013/08/29 22:45:13]

So I don't have an example to point to right now, but I remember us occasionally
triggering on the wrong form on a page. For instance, say the sign up and login
forms are on the same page, and the login page has "hidden" fields which aren't
actually type="hidden". In this case, specifying the exact form you mean would
be useful, so I think that we should probably send a vector of FormData's down
instead. We can switch the actual comparison in a later CL, as soon we should be
able to easily get FormData from PasswordForm.

[zysxqn, 2013/09/03 23:00:20]

Done.

+        break;
+      }
+    }
+  }
+  SendAccountCreationFormsToRenderer(web_contents()->GetRenderViewHost(),
+                                     account_creation_form_origins);
+}
+
 void PasswordGenerationManager::RegisterWithSyncService() {
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
   ProfileSyncService* sync_service =
       ProfileSyncServiceFactory::GetForProfile(profile);
   if (sync_service)
     sync_service->AddObserver(this);
 }
 
 void PasswordGenerationManager::SetUpPrefChangeRegistrar() {
@@ skipping 76 matching lines @@
     SendStateToRenderer(host, enabled_);
   }
 }
 
 void PasswordGenerationManager::SendStateToRenderer(
     content::RenderViewHost* host, bool enabled) {
   host->Send(new AutofillMsg_PasswordGenerationEnabled(host->GetRoutingID(),
                                                        enabled));
 }
 
+void PasswordGenerationManager::SendAccountCreationFormsToRenderer(
+    content::RenderViewHost* host, const std::vector<GURL>& origins) {
+  host->Send(new AutofillMsg_AccountCreationFormsDetected(
+      host->GetRoutingID(), origins));
+}

[Ilya Sherman, 2013/08/29 23:08:13]

nit: Why not just inline this method?

[zysxqn, 2013/09/03 23:00:20]

I don't have strong preference on this one but I use a separate method for the
following reasons:

(1) To be consistent with SendStateToRenderer()

(2) It's a bit cleaner since we need to refer to "host" twice in the method.

Are you fine with this?

+
 void PasswordGenerationManager::OnShowPasswordGenerationPopup(
     const gfx::Rect& bounds,
     int max_length,
     const content::PasswordForm& form) {
 #if defined(OS_ANDROID)
   NOTIMPLEMENTED();
 #else
   password_generator_.reset(new autofill::PasswordGenerator(max_length));
   Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
   browser->window()->ShowPasswordGenerationBubble(bounds,
                                                   form,
                                                   password_generator_.get());
 #endif  // #if defined(OS_ANDROID)
 }