Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2343183002: Fix service test websocket error edge case (Closed)

Created:
4 years, 3 months ago by Cutch
Modified:
4 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -35 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 3 chunks +17 lines, -13 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 3 chunks +5 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
4 years, 3 months ago (2016-09-16 17:27:32 UTC) #2
rmacnak
lgtm
4 years, 3 months ago (2016-09-16 17:30:19 UTC) #3
Cutch
4 years, 3 months ago (2016-09-16 17:31:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2b922b4c5b54e5b044ff6c435ed73a1e3ef218a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698