MD Settings: Ensure that after clearing search, the "basic" page is displayed.

MD Settings: After clearing search, always display the "basic" page.

If the search was initiated by a subpage whose parent was the "advanced" page
(for example Site Settings), after clearing the search results, only the
contents of the "advanced" page were shown.

 - Replacing previousSearchPages_ with a single inSearchMode_ boolean.
 - Determining whether the "advanced" page should be restored by using the
   existing advancedToggleExpanded_ boolean. Other parts of settings_main.js
   already treat that boolean as the source of truth.

BUG=638915
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6fb3dc8814cdc4f02ffe147f0d9caf34827a2175
Cr-Commit-Position: refs/heads/master@{#419823}

[dpapad, 2016-09-16 23:02:18]

Description was changed from

==========
MD Settings: Ensure that after clearing search, the "basic" page is displayed.

If the search was initiated by a subpage whose parent was the "advanced" page
(for example Site Settings), after clearing the search results, only the
contents of the "advanced" page were shown.

BUG=638915
==========

to

==========
MD Settings: Ensure that after clearing search, the "basic" page is displayed.

If the search was initiated by a subpage whose parent was the "advanced" page
(for example Site Settings), after clearing the search results, only the
contents of the "advanced" page were shown.

BUG=638915
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-09-16 23:04:14]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2016-09-16 23:04:26]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-09-16 23:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-09-16 23:05:04]

Description was changed from

==========
MD Settings: Ensure that after clearing search, the "basic" page is displayed.

If the search was initiated by a subpage whose parent was the "advanced" page
(for example Site Settings), after clearing the search results, only the
contents of the "advanced" page were shown.

BUG=638915
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: After clearing search, always display the "basic" page.

If the search was initiated by a subpage whose parent was the "advanced" page
(for example Site Settings), after clearing the search results, only the
contents of the "advanced" page were shown.

BUG=638915
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-09-16 23:25:15]

Patchset #1 (id:20001) has been deleted

[dpapad, 2016-09-16 23:43:35]

Patchset #1 (id:40001) has been deleted

[dpapad, 2016-09-16 23:43:39]

Patchset #1 (id:60001) has been deleted

[dpapad, 2016-09-16 23:47:09]

Description was changed from

==========
MD Settings: After clearing search, always display the "basic" page.

If the search was initiated by a subpage whose parent was the "advanced" page
(for example Site Settings), after clearing the search results, only the
contents of the "advanced" page were shown.

BUG=638915
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: After clearing search, always display the "basic" page.

If the search was initiated by a subpage whose parent was the "advanced" page
(for example Site Settings), after clearing the search results, only the
contents of the "advanced" page were shown.

 - Replacing previousSearchPages_ with a single inSearchMode_ boolean.
 - Determining whether the "advanced" page should be restored by using the
   existing advancedToggleExpanded_ boolean. Other parts of settings_main.js
   already treat that boolean as the source of truth.

BUG=638915
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-09-16 23:47:17]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 23:47:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:58:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:58:38]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dpapad, 2016-09-17 00:16:02]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 00:16:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 01:14:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 01:14:09]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-09-17 01:53:21]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-09-20 01:22:17]

Friendly ping.

[Dan Beam, 2016-09-20 02:45:29]

lgtm

[dpapad, 2016-09-20 17:33:56]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-09-20 17:34:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 18:35:35]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-09-20 18:38:16]

Description was changed from

==========
MD Settings: After clearing search, always display the "basic" page.

If the search was initiated by a subpage whose parent was the "advanced" page
(for example Site Settings), after clearing the search results, only the
contents of the "advanced" page were shown.

 - Replacing previousSearchPages_ with a single inSearchMode_ boolean.
 - Determining whether the "advanced" page should be restored by using the
   existing advancedToggleExpanded_ boolean. Other parts of settings_main.js
   already treat that boolean as the source of truth.

BUG=638915
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: After clearing search, always display the "basic" page.

If the search was initiated by a subpage whose parent was the "advanced" page
(for example Site Settings), after clearing the search results, only the
contents of the "advanced" page were shown.

 - Replacing previousSearchPages_ with a single inSearchMode_ boolean.
 - Determining whether the "advanced" page should be restored by using the
   existing advancedToggleExpanded_ boolean. Other parts of settings_main.js
   already treat that boolean as the source of truth.

BUG=638915
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6fb3dc8814cdc4f02ffe147f0d9caf34827a2175
Cr-Commit-Position: refs/heads/master@{#419823}
==========

[commit-bot: I haz the power, 2016-09-20 18:38:17]

Patchset 2 (id:??) landed as
https://crrev.com/6fb3dc8814cdc4f02ffe147f0d9caf34827a2175
Cr-Commit-Position: refs/heads/master@{#419823}