Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/telemetry/telemetry/page/page_measurement_value.py

Issue 23431036: Create and display "comparison statistics" to compare two statistics Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync'd to r233008. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_results.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_measurement_value.py
diff --git a/tools/telemetry/telemetry/page/page_measurement_value.py b/tools/telemetry/telemetry/page/page_measurement_value.py
index c2c8e0e09128d995fde035631a6eb7302e10171a..f2630aaaa22375855054b88047dd1a37ea2bcebd 100644
--- a/tools/telemetry/telemetry/page/page_measurement_value.py
+++ b/tools/telemetry/telemetry/page/page_measurement_value.py
@@ -6,6 +6,18 @@ from telemetry.page import perf_tests_helper
def _Mean(l):
return float(sum(l)) / len(l) if len(l) > 0 else 0.0
+def MeasurementName(chart_name, trace_name):
+ if chart_name:
+ return '%s.%s' % (chart_name, trace_name)
+ else:
+ return trace_name
+
+def ChartTraceFromMeasurement(measurement_name):
+ if "." in measurement_name:
+ return measurement_name.split('.', 1)
+ else:
+ return ('', measurement_name)
+
class PageMeasurementValue(object):
def __init__(self, trace_name, units, value, chart_name, data_type):
self.trace_name = trace_name
@@ -16,10 +28,7 @@ class PageMeasurementValue(object):
@property
def measurement_name(self):
- if self.chart_name:
- return '%s.%s' % (self.chart_name, self.trace_name)
- else:
- return self.trace_name
+ return MeasurementName(self.chart_name, self.trace_name)
@property
def output_value(self):
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_results.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698