Create and display "comparison statistics" to compare two statistics

tools/telemetry/telemetry/page/buildbot_page_measurement_results.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 from itertools import chain
 
 from telemetry.page import page_measurement_results
+from telemetry.page import page_measurement_value
 from telemetry.page import perf_tests_helper
 
 class BuildbotPageMeasurementResults(
     page_measurement_results.PageMeasurementResults):
   def __init__(self, trace_tag=''):
     super(BuildbotPageMeasurementResults, self).__init__()
     self._trace_tag = trace_tag
 
   def _PrintPerfResult(self, measurement, trace, values, units,
                        result_type='default'):
@@ skipping 43 matching lines @@
     # Output the results summary sorted by measurement name, then units, then
     # data type.
     for measurement_units_type, value_and_display_name_list in sorted(
         results_summary.iteritems()):
       measurement, units, data_type = measurement_units_type
 
       if 'histogram' in data_type:
         by_name_data_type = 'unimportant-histogram'
       else:
         by_name_data_type = 'unimportant'
-      if '.' in measurement and 'histogram' not in data_type:
-        measurement, trace = measurement.split('.', 1)
-        trace += self._trace_tag
-      else:
-        trace = measurement + self._trace_tag
+
+      trace = ''
+      if 'histogram' not in data_type:
+        measurement, trace = \
+            page_measurement_value.ChartTraceFromMeasurement(measurement)
+      if not measurement:
+        measurement = trace
+      trace += self._trace_tag
 
       # Print individual _by_name results if there's more than 1 successful
       # page, or if there's exactly 1 successful page but a failure exists.
       if not self._trace_tag and (len(value_and_display_name_list) > 1 or
           ((self.errors or self.failures) and
            len(value_and_display_name_list) == 1)):
         name_value_map = defaultdict(list)
         for value, name in value_and_display_name_list:
           if 'histogram' in data_type and name_value_map[name]:
             # TODO(tonyg/marja): The histogram processing code only accepts one
@@ skipping 12 matching lines @@
       # For histograms, we don't print the average data, only the _by_name,
       # unless there is only 1 page in which case the _by_names are omitted.
       if not (self.errors or self.failures):
         if ('histogram' not in data_type or
             len(value_and_display_name_list) == 1):
           values = [i[0] for i in value_and_display_name_list]
           if isinstance(values[0], list):
             values = list(chain.from_iterable(values))
           self._PrintPerfResult(measurement, trace, values, units, data_type)
 
+    # Output all the by_name comparisons.  This is safe no matter
+    # whether the _by_name results above were output, as the final
+    # display needs to detect and ignore comparisons that refer to
+    # non-existent base statistics.
+    for compare_stat in [x for x in self._comparison_stats.iteritems()]:
+      (result_stat_measurement, result_stat_trace) = \
+          page_measurement_value.ChartTraceFromMeasurement(compare_stat[0])
+      if not result_stat_measurement:
+        result_stat_measurement = result_stat_trace
+      (ref_stat_measurement, ref_stat_trace) = \
+          page_measurement_value.ChartTraceFromMeasurement(
+        compare_stat[1]['reference'])
+      if not ref_stat_measurement:
+        ref_stat_measurement = ref_stat_trace
+      (comparison_stat_measurement, comparison_stat_trace) = \
+          page_measurement_value.ChartTraceFromMeasurement(
+        compare_stat[1]['comparison'])
+      if not comparison_stat_measurement:
+        comparison_stat_measurement = comparison_stat_trace
+      for name in unique_pages:
+        self.AddComparison(name, ref_stat_measurement + '_by_url',
+                           name, comparison_stat_measurement + '_by_url',
+                           name, result_stat_measurement + '_by_url')
+
     # If there were no failed pages, output the overall results (results not
     # associated with a page).
     if not (self.errors or self.failures):
       for value in self._overall_results:
         values = value.value
         if not isinstance(values, list):
           values = [values]
         measurement_name = value.chart_name
         if not measurement_name:
           measurement_name = value.trace_name
         self._PrintPerfResult(measurement_name,
                               value.trace_name + self._trace_tag,
                               values, value.units, value.data_type)
 
     # Print the number of failed and errored pages.
     self._PrintPerfResult('telemetry_page_measurement_results', 'num_failed',
                           [len(self.failures)], 'count', 'unimportant')
     self._PrintPerfResult('telemetry_page_measurement_results', 'num_errored',
                           [len(self.errors)], 'count', 'unimportant')
 
     super(BuildbotPageMeasurementResults, self).PrintSummary()