Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2343103003: ImportElement/ExportElement 'uri' should be the selected URI. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

ImportElement/ExportElement 'uri' should be the selected URI. So, that the URI is consistent with the imported/exportedLibrary. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/54ee2b88c832161561306674bb12a6d2f2ae63ab

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -10 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +8 lines, -0 lines 3 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +13 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 3 months ago (2016-09-17 00:05:18 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2343103003/diff/1/pkg/analyzer/lib/dart/ast/ast.dart File pkg/analyzer/lib/dart/ast/ast.dart (right): https://codereview.chromium.org/2343103003/diff/1/pkg/analyzer/lib/dart/ast/ast.dart#newcode5981 pkg/analyzer/lib/dart/ast/ast.dart:5981: String get selectedUri; Not sure I like the ...
4 years, 3 months ago (2016-09-17 00:27:42 UTC) #2
scheglov
https://codereview.chromium.org/2343103003/diff/1/pkg/analyzer/lib/dart/ast/ast.dart File pkg/analyzer/lib/dart/ast/ast.dart (right): https://codereview.chromium.org/2343103003/diff/1/pkg/analyzer/lib/dart/ast/ast.dart#newcode5981 pkg/analyzer/lib/dart/ast/ast.dart:5981: String get selectedUri; On 2016/09/17 00:27:42, Brian Wilkerson wrote: ...
4 years, 3 months ago (2016-09-17 02:01:57 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2343103003/diff/1/pkg/analyzer/lib/dart/ast/ast.dart File pkg/analyzer/lib/dart/ast/ast.dart (right): https://codereview.chromium.org/2343103003/diff/1/pkg/analyzer/lib/dart/ast/ast.dart#newcode5981 pkg/analyzer/lib/dart/ast/ast.dart:5981: String get selectedUri; > It should be selectedUriContent, as ...
4 years, 3 months ago (2016-09-17 02:27:13 UTC) #4
scheglov
4 years, 3 months ago (2016-09-18 00:26:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
54ee2b88c832161561306674bb12a6d2f2ae63ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698