Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 2343103002: GN: add a flag to implement Android_FrameworkDefs bot. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: add a flag to implement Android_FrameworkDefs bot. This bot builds Skia with a bunch of defines to mimic the Android roll. Apparently it was supposed to be on the CQ... I'll add the GN version to it when it exists. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343103002 Committed: https://skia.googlesource.com/skia/+/1bd72ba2cb349788223e3e7304f25751c87f1f95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M BUILD.gn View 3 chunks +8 lines, -0 lines 0 comments Download
M gn/shared_sources.gni View 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
4 years, 3 months ago (2016-09-16 14:10:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343103002/1
4 years, 3 months ago (2016-09-16 14:10:13 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-16 14:10:14 UTC) #7
djsollen
lgtm
4 years, 3 months ago (2016-09-16 14:36:17 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 14:45:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1bd72ba2cb349788223e3e7304f25751c87f1f95

Powered by Google App Engine
This is Rietveld 408576698