add the option to bisect blink builds as well and have blink revisions look in the REVISIONS file a…

add the option to bisect blink builds as well and have blink revisions look in the REVISIONS file and not DEPS

R=rsesek@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223632

[Dirk Pranke, 2013-09-17 00:42:18]

https://codereview.chromium.org/23431026/diff/2001/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/23431026/diff/2001/tools/bisect-builds.py#new...
tools/bisect-builds.py:751: min_blink_rev =
GetBlinkRevisionForChromiumRevision(context,
I don't think you need (or want) the 'context' parameter on these two calls.

You probably also shouldn't be silently ignoring the failures, since they
shouldn't happen if I am understanding things correctly.

[kareng, 2013-09-17 00:47:13]

On 2013/09/17 00:42:18, Dirk Pranke wrote:
> https://codereview.chromium.org/23431026/diff/2001/tools/bisect-builds.py
> File tools/bisect-builds.py (right):
> 
>
https://codereview.chromium.org/23431026/diff/2001/tools/bisect-builds.py#new...
> tools/bisect-builds.py:751: min_blink_rev =
> GetBlinkRevisionForChromiumRevision(context,
> I don't think you need (or want) the 'context' parameter on these two calls.
> 
> You probably also shouldn't be silently ignoring the failures, since they
> shouldn't happen if I am understanding things correctly.

i meant to change function to take "self", done :)

[Robert Sesek, 2013-09-17 13:45:34]

Nifty! I look forward to using this.

https://codereview.chromium.org/23431026/diff/6001/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/23431026/diff/6001/tools/bisect-builds.py#new...
tools/bisect-builds.py:620: if data['webkit_revision']:
if 'webkit_revision' in data: is a safer way to do this.

https://codereview.chromium.org/23431026/diff/6001/tools/bisect-builds.py#new...
tools/bisect-builds.py:623: raise Exception('Could not get webkit revision for
cr rev %d' % rev)
I'd keep this as blink, since that's what the option says.

https://codereview.chromium.org/23431026/diff/6001/tools/bisect-builds.py#new...
tools/bisect-builds.py:713: 
nit: remove extra blank line

[kareng, 2013-09-17 17:15:48]

On 2013/09/17 13:45:34, rsesek wrote:
> Nifty! I look forward to using this.
> 
> https://codereview.chromium.org/23431026/diff/6001/tools/bisect-builds.py
> File tools/bisect-builds.py (right):
> 
>
https://codereview.chromium.org/23431026/diff/6001/tools/bisect-builds.py#new...
> tools/bisect-builds.py:620: if data['webkit_revision']:
> if 'webkit_revision' in data: is a safer way to do this.
> 
>
https://codereview.chromium.org/23431026/diff/6001/tools/bisect-builds.py#new...
> tools/bisect-builds.py:623: raise Exception('Could not get webkit revision for
> cr rev %d' % rev)
> I'd keep this as blink, since that's what the option says.
> 
>
https://codereview.chromium.org/23431026/diff/6001/tools/bisect-builds.py#new...
> tools/bisect-builds.py:713: 
> nit: remove extra blank line

all fixed ty! :)

[Robert Sesek, 2013-09-17 17:24:05]

lgtm

[kareng, 2013-09-17 17:44:09]

Committed patchset #4 manually as r223632 (presubmit successful).

[Nico, 2013-09-19 01:52:16]

Whoa, nice! Can you update http://www.chromium.org/developers/bisect-builds-py
with how to use this for blink?

[kareng, 2013-09-20 20:25:02]

On 2013/09/19 01:52:16, Nico wrote:
> Whoa, nice! Can you update http://www.chromium.org/developers/bisect-builds-py
> with how to use this for blink?

sure thing. i have one more commit https://codereview.chromium.org/23629048 that
needs to land and then i'll update the docs accordingly :)

[kareng, 2013-10-01 00:03:45]

On 2013/09/20 20:25:02, kareng wrote:
> On 2013/09/19 01:52:16, Nico wrote:
> > Whoa, nice! Can you update
http://www.chromium.org/developers/bisect-builds-py
> > with how to use this for blink?
> 
> sure thing. i have one more commit https://codereview.chromium.org/23629048
that
> needs to land and then i'll update the docs accordingly :)

updated the doc nico.

[Dirk Pranke, 2013-10-02 18:21:17]

Nice. We should look at the logic in the perf bisect script (which will
automatically drill into a blink roll) and see if we can apply that here. It
almost certainly can't be reused as-is (since it is building from source and can
control the revisions), but maybe there's something that can be leveraged.