Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1316)

Unified Diff: Source/core/platform/graphics/GraphicsLayer.h

Issue 23431021: Refactoring animation code in accelerated path. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/platform/graphics/GraphicsLayer.h
diff --git a/Source/core/platform/graphics/GraphicsLayer.h b/Source/core/platform/graphics/GraphicsLayer.h
index 7572b3c497513d32f94d81351005fc0eac501019..6d358cf5be171f880a955b4cda0b1d5a9f724ee9 100644
--- a/Source/core/platform/graphics/GraphicsLayer.h
+++ b/Source/core/platform/graphics/GraphicsLayer.h
@@ -27,8 +27,6 @@
#ifndef GraphicsLayer_h
#define GraphicsLayer_h
-#include "core/platform/animation/CSSAnimationData.h"
-#include "core/platform/animation/KeyframeValueList.h"
#include "core/platform/graphics/Color.h"
#include "core/platform/graphics/FloatPoint.h"
#include "core/platform/graphics/FloatPoint3D.h"
@@ -39,7 +37,6 @@
#include "core/platform/graphics/filters/FilterOperations.h"
#include "core/platform/graphics/transforms/TransformationMatrix.h"
-#include "wtf/HashMap.h"
#include "wtf/OwnPtr.h"
#include "wtf/PassOwnPtr.h"
@@ -54,6 +51,7 @@
namespace WebKit {
class GraphicsLayerFactoryChromium;
+class WebAnimation;
class WebLayer;
}
@@ -218,15 +216,12 @@ public:
IntRect contentsRect() const { return m_contentsRect; }
void setContentsRect(const IntRect&);
- // Transitions are identified by a special animation name that cannot clash with a keyframe identifier.
- static String animationNameForTransition(AnimatedPropertyID);
-
// Return true if the animation is handled by the compositing system. If this returns
// false, the animation will be run by AnimationController.
// These methods handle both transitions and keyframe animations.
- bool addAnimation(const KeyframeValueList&, const IntSize& /*boxSize*/, const CSSAnimationData*, const String& /*animationName*/, double /*timeOffset*/);
- void pauseAnimation(const String& /*animationName*/, double /*timeOffset*/);
- void removeAnimation(const String& /*animationName*/);
+ bool addAnimation(WebKit::WebAnimation*);
+ void pauseAnimation(int animationId, double /*timeOffset*/);
+ void removeAnimation(int animationId);
void suspendAnimations(double time);
void resumeAnimations();
@@ -407,9 +402,6 @@ private:
ContentsLayerPurpose m_contentsLayerPurpose;
- typedef HashMap<String, int> AnimationIdMap;
- AnimationIdMap m_animationIdMap;
-
ScrollableArea* m_scrollableArea;
WebKit::WebCompositingReasons m_compositingReasons;
};

Powered by Google App Engine
This is Rietveld 408576698