Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2139)

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 23431015: Shard based on relative originTestPath (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_suite.dart
diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart
index 0b6904b50451117bbf0b3a123970f08b78962b45..aeb782b9bd7f4bf6bf4ead0f5d33efa37556ff10 100644
--- a/dart/tools/testing/dart/test_suite.dart
+++ b/dart/tools/testing/dart/test_suite.dart
@@ -273,11 +273,12 @@ abstract class TestSuite {
int shards = configuration['shards'];
if (shards > 1) {
int shard = configuration['shard'];
- if ("${testCase.info.originTestPath}".hashCode % shards != shard - 1) {
+ var testPath =
+ testCase.info.originTestPath.relativeTo(TestUtils.dartDir());
+ if ("$testPath".hashCode % shards != shard - 1) {
return;
}
}
-
// Test if the selector includes this test.
RegExp pattern = configuration['selectors'][suiteName];
if (!pattern.hasMatch(testCase.displayName)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698