Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2343093002: Also build parsing/test-scanner-streams. (Closed)

Created:
4 years, 3 months ago by vogelheim
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Also build parsing/test-scanner-streams. crrev.com/2339933002 and crrev.com/2314663002 were overlapping, so this slipped through the cracks. R=jochen@chromium.org BUG=v8:4947, chromium:646794 Committed: https://crrev.com/8d007434386dfdeabd217c873b9d97b2c3e3b5ee Cr-Commit-Position: refs/heads/master@{#39474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/cctest/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
vogelheim
ptal.
4 years, 3 months ago (2016-09-16 13:13:46 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-16 13:18:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343093002/1
4 years, 3 months ago (2016-09-16 13:57:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 13:59:46 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 14:00:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d007434386dfdeabd217c873b9d97b2c3e3b5ee
Cr-Commit-Position: refs/heads/master@{#39474}

Powered by Google App Engine
This is Rietveld 408576698