Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Unified Diff: chrome/BUILD.gn

Issue 2343083003: Add resource whitelisting to android_webview pak files. (Closed)
Patch Set: better docs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/webview_repack_locales.gni ('k') | tools/resources/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 36cad983fc6a72f38b796c113764bedccb0574d0..eddc62a86742ec01a682f6ac51ba0dfb036afdad 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -15,6 +15,7 @@ import("//chrome/chrome_paks.gni")
import("//chrome/common/features.gni")
import("//chrome/process_version_rc_template.gni")
import("//third_party/widevine/cdm/widevine.gni")
+import("//tools/resources/generate_resource_whitelist.gni")
import("//ui/base/ui_features.gni")
import("//v8/gni/v8.gni")
@@ -1476,33 +1477,12 @@ if (is_android) {
}
if (enable_resource_whitelist_generation) {
- action("resource_whitelist") {
- assert(is_android,
- "Resource whitelist currently implemented only on Android")
-
+ generate_resource_whitelist("resource_whitelist") {
deps = [
"//chrome/android:chrome",
]
- script = "//tools/resources/generate_resource_whitelist.py"
-
- _infile = "$root_out_dir/libchrome$shlib_extension.whitelist"
- inputs = [
- _infile,
- ]
-
- _outfile = chrome_resource_whitelist
- outputs = [
- _outfile,
- ]
-
- args = [
- "-i",
- rebase_path(_infile, root_build_dir),
- "-o",
- rebase_path(_outfile, root_build_dir),
- "--out-dir=.",
- "--use-existing-resource-ids",
- ]
+ input = "$root_out_dir/libchrome$shlib_extension.whitelist"
+ output = chrome_resource_whitelist
}
}
« no previous file with comments | « android_webview/webview_repack_locales.gni ('k') | tools/resources/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698