Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Unified Diff: android_webview/webview_repack_locales.gni

Issue 2343083003: Add resource whitelisting to android_webview pak files. (Closed)
Patch Set: better docs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/BUILD.gn ('k') | chrome/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/webview_repack_locales.gni
diff --git a/android_webview/webview_repack_locales.gni b/android_webview/webview_repack_locales.gni
index c4655ee0d50ddcd976ea22642b21798ed3b0630b..9e2ead4625c902d6a3cbf3f36d7b5d5e6a47248d 100644
--- a/android_webview/webview_repack_locales.gni
+++ b/android_webview/webview_repack_locales.gni
@@ -10,6 +10,9 @@ import("webview_repack_locales_list.gni")
template("webview_repack_locales") {
repack_locales(target_name) {
forward_variables_from(invoker, "*")
+ if (!defined(deps)) {
+ deps = []
+ }
# Adding webview specific pak file? You should add it to
# webview_repack_locales_source_patterns, so it is also included in
@@ -20,7 +23,7 @@ template("webview_repack_locales") {
"${root_gen_dir}/content/app/strings/content_strings_",
"${root_gen_dir}/ui/strings/app_locale_settings_",
]
- deps = [
+ deps += [
"//android_webview:generate_components_strings",
"//content/app/strings",
"//ui/strings:app_locale_settings",
« no previous file with comments | « android_webview/BUILD.gn ('k') | chrome/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698