Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: tools/resources/generate_resource_whitelist.gni

Issue 2343083003: Add resource whitelisting to android_webview pak files. (Closed)
Patch Set: add owners file Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« android_webview/BUILD.gn ('K') | « tools/resources/OWNERS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/resources/generate_resource_whitelist.gni
diff --git a/tools/resources/generate_resource_whitelist.gni b/tools/resources/generate_resource_whitelist.gni
new file mode 100644
index 0000000000000000000000000000000000000000..55808646923039764064cf6048f501c250fb66c0
--- /dev/null
+++ b/tools/resources/generate_resource_whitelist.gni
@@ -0,0 +1,42 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
Nico 2016/09/19 20:27:49 can you explain some more what this actually does?
agrieve 2016/09/20 00:48:34 Done.
+# Adds IDS_VERSION_UI_32BIT and IDS_VERSION_UI_64BIT to a given whitelist.
+#
+# Variables
+# input: Path to the .whitelist created by the toolchain.
+# output: Path to write the output whitelist to.
+#
+# Example
+# generate_resource_whitelist("pak_whitelist") {
+# deps = [ ":my_shared_library" ]
+# input = "$root_out_dir/libmy_shared_library$shlib_extension.whitelist"
+# output = "$target_gen_dir/pak_whitelist.txt"
+# }
+template("generate_resource_whitelist") {
+ action(target_name) {
+ forward_variables_from(invoker, [ "deps" ])
+ assert(is_android,
+ "Resource whitelist currently implemented only on Android")
+
+ script = "//tools/resources/generate_resource_whitelist.py"
+
+ inputs = [
+ invoker.input,
+ ]
+
+ outputs = [
+ invoker.output,
+ ]
+
+ args = [
+ "-i",
+ rebase_path(invoker.input, root_build_dir),
+ "-o",
+ rebase_path(invoker.output, root_build_dir),
+ "--out-dir=.",
+ "--use-existing-resource-ids",
+ ]
+ }
+}
« android_webview/BUILD.gn ('K') | « tools/resources/OWNERS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698