Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2343063004: Enable copy and assignment for Printer objects. (Closed)

Created:
4 years, 3 months ago by skau
Modified:
4 years, 3 months ago
Reviewers:
Carlson, xdai1
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable copy and assignment for Printer objects. Printer objects are just data. There are instances where copying them is convenient and it should always be safe. BUG= Committed: https://crrev.com/6fadfc318f736a499323b06da37e4abce3d27709 Cr-Commit-Position: refs/heads/master@{#419608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chromeos/printing/printer_configuration.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chromeos/printing/printer_configuration.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
skau
Printer is a data object and it's become cumbersome if it's not copyable. It also ...
4 years, 3 months ago (2016-09-17 01:02:53 UTC) #2
xdai1
lgtm
4 years, 3 months ago (2016-09-19 18:30:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343063004/1
4 years, 3 months ago (2016-09-19 23:49:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 00:22:20 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 00:24:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fadfc318f736a499323b06da37e4abce3d27709
Cr-Commit-Position: refs/heads/master@{#419608}

Powered by Google App Engine
This is Rietveld 408576698