Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2343063002:
ThinLTO: workaround LLVM bug related to -nostdlib. (Closed)
|
Created:
4 years, 3 months ago by krasin1 Modified:
4 years, 3 months ago Reviewers:
Mark Seaborn CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionThinLTO: workaround an LLVM bug related to -nostdlib.
In short, an LTO optimization pass might recognize
naive implementations of builtins (such as memset)
and replace them with references to the real builtins,
which, in the case of -nostdlib, might cause the binary
to get undefined references to those symbols.
See more details:
https://llvm.org/bugs/show_bug.cgi?id=30403
BUG=645295
Committed: https://crrev.com/538cb2b112587d65560fa818d6e707ac54bf553c
Cr-Commit-Position: refs/heads/master@{#419233}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add more explanations #Patch Set 3 : revert debug change #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
krasin@chromium.org changed reviewers: + mseaborn@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== ThinLTO: workaround LLVM bug related to -nostdlib. In short, an LTO optimization pass might recognize naive implementations of builtins (such as memset) and replace them with references to the real builtins, which, in the case of -nostdlib, might cause the binary to get undefined references to those symbols. See more details: https://llvm.org/bugs/show_bug.cgi?id=30403 BUG=645295 ========== to ========== ThinLTO: workaround an LLVM bug related to -nostdlib. In short, an LTO optimization pass might recognize naive implementations of builtins (such as memset) and replace them with references to the real builtins, which, in the case of -nostdlib, might cause the binary to get undefined references to those symbols. See more details: https://llvm.org/bugs/show_bug.cgi?id=30403 BUG=645295 ==========
LGTM https://codereview.chromium.org/2343063002/diff/1/chrome/test/data/nacl/BUILD.gn File chrome/test/data/nacl/BUILD.gn (right): https://codereview.chromium.org/2343063002/diff/1/chrome/test/data/nacl/BUILD... chrome/test/data/nacl/BUILD.gn:558: # Workaround against LLVM bug: Can you put the explanation that's in the commit message in this comment, please?
Thank you, Mark! https://codereview.chromium.org/2343063002/diff/1/chrome/test/data/nacl/BUILD.gn File chrome/test/data/nacl/BUILD.gn (right): https://codereview.chromium.org/2343063002/diff/1/chrome/test/data/nacl/BUILD... chrome/test/data/nacl/BUILD.gn:558: # Workaround against LLVM bug: On 2016/09/16 17:30:46, Mark Seaborn wrote: > Can you put the explanation that's in the commit message in this comment, > please? Done.
The CQ bit was checked by krasin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mseaborn@chromium.org Link to the patchset: https://codereview.chromium.org/2343063002/#ps40001 (title: "revert debug change")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== ThinLTO: workaround an LLVM bug related to -nostdlib. In short, an LTO optimization pass might recognize naive implementations of builtins (such as memset) and replace them with references to the real builtins, which, in the case of -nostdlib, might cause the binary to get undefined references to those symbols. See more details: https://llvm.org/bugs/show_bug.cgi?id=30403 BUG=645295 ========== to ========== ThinLTO: workaround an LLVM bug related to -nostdlib. In short, an LTO optimization pass might recognize naive implementations of builtins (such as memset) and replace them with references to the real builtins, which, in the case of -nostdlib, might cause the binary to get undefined references to those symbols. See more details: https://llvm.org/bugs/show_bug.cgi?id=30403 BUG=645295 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== ThinLTO: workaround an LLVM bug related to -nostdlib. In short, an LTO optimization pass might recognize naive implementations of builtins (such as memset) and replace them with references to the real builtins, which, in the case of -nostdlib, might cause the binary to get undefined references to those symbols. See more details: https://llvm.org/bugs/show_bug.cgi?id=30403 BUG=645295 ========== to ========== ThinLTO: workaround an LLVM bug related to -nostdlib. In short, an LTO optimization pass might recognize naive implementations of builtins (such as memset) and replace them with references to the real builtins, which, in the case of -nostdlib, might cause the binary to get undefined references to those symbols. See more details: https://llvm.org/bugs/show_bug.cgi?id=30403 BUG=645295 Committed: https://crrev.com/538cb2b112587d65560fa818d6e707ac54bf553c Cr-Commit-Position: refs/heads/master@{#419233} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/538cb2b112587d65560fa818d6e707ac54bf553c Cr-Commit-Position: refs/heads/master@{#419233} |
