Service worker bypass for resource requests from suborigins

third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
     Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 1014 matching lines @@
 {
     DCHECK(resource && resource->stillNeedsLoad());
     if (!context().shouldLoadNewResource(resource->getType())) {
         memoryCache()->remove(resource);
         return false;
     }
 
     ResourceRequest request(resource->resourceRequest());
     willSendRequest(resource->identifier(), request, ResourceResponse(), resource->options());
 
+    SecurityOrigin* sourceOrigin = context().getSecurityOrigin();
+    if (sourceOrigin && sourceOrigin->hasSuborigin())
+        request.setSkipServiceWorker(WebURLRequest::SkipServiceWorker::All);

[falken, 2016/09/20 03:48:57]

I know this is Blink but can we comment here why sw are being skipped?

[jww, 2016/09/20 04:27:47]

Hahaha, I like you're style :-) I always get ticked off with the lack of
comments. Done.

+
     ResourceLoader* loader = ResourceLoader::create(this, resource);
     if (resource->shouldBlockLoadEvent())
         m_loaders.add(loader);
     else
         m_nonBlockingLoaders.add(loader);
 
     storeResourceTimingInitiatorInformation(resource);
-    resource->setFetcherSecurityOrigin(context().getSecurityOrigin());
+    resource->setFetcherSecurityOrigin(sourceOrigin);
     loader->start(request, context().loadingTaskRunner(), context().defersLoading());
     return true;
 }
 
 void ResourceFetcher::removeResourceLoader(ResourceLoader* loader)
 {
     if (m_loaders.contains(loader))
         m_loaders.remove(loader);
     else if (m_nonBlockingLoaders.contains(loader))
         m_nonBlockingLoaders.remove(loader);
@@ skipping 270 matching lines @@
     visitor->trace(m_context);
     visitor->trace(m_archive);
     visitor->trace(m_loaders);
     visitor->trace(m_nonBlockingLoaders);
     visitor->trace(m_documentResources);
     visitor->trace(m_preloads);
     visitor->trace(m_resourceTimingInfoMap);
 }
 
 } // namespace blink