Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Issue 2343033002: IPC: Delete thread-safe send support (Closed)

Created:
4 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 3 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, cmumford, darin (slow to review), darin-cc_chromium.org, jsbell+idb_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IPC: Delete thread-safe send support We ended up not using it, and there are no plans to use it in the future. It adds some unnecessary complexity to SyncMessageFilter which I don't want to have to maintain as I add some extra support for associated interfaces. BUG=612500 R=jam@chromium.org Committed: https://crrev.com/b97e3d3f0aeef861bc378c1243406835a52d3569 Cr-Commit-Position: refs/heads/master@{#419205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -70 lines) Patch
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/indexed_db/webidbcursor_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/gpu/queue_message_swap_promise_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_channel_common.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_channel_mojo.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_mojo.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 3 chunks +0 lines, -7 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 2 chunks +1 line, -6 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_message_filter.h View 3 chunks +1 line, -10 lines 0 comments Download
M ipc/ipc_sync_message_filter.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M ppapi/nacl_irt/manifest_service.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Ken Rockot(use gerrit already)
4 years, 3 months ago (2016-09-16 00:22:31 UTC) #4
jam
just to be clear, this is for old IPC and not for mojo right? if ...
4 years, 3 months ago (2016-09-16 16:36:53 UTC) #7
Ken Rockot(use gerrit already)
Correct On Sep 16, 2016 9:36 AM, <jam@chromium.org> wrote: > just to be clear, this ...
4 years, 3 months ago (2016-09-16 17:33:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343033002/1
4 years, 3 months ago (2016-09-16 17:33:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 17:39:23 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 17:44:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b97e3d3f0aeef861bc378c1243406835a52d3569
Cr-Commit-Position: refs/heads/master@{#419205}

Powered by Google App Engine
This is Rietveld 408576698