chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellInterface.java - Issue 2343023002: Switch WebVR to handle GvrApi management through VrShellDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellInterface.java

Issue 2343023002: Switch WebVR to handle GvrApi management through VrShellDelegate (Closed)

Patch Set: Renamed onNativeLibraryReady to initializeNative Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellInterface.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellInterface.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellInterface.java

index 1c6123c7081eaa91840ea9fb922e52bf271ce921..0e5c77aa069912c15c2ed573db6c1656fe379e7c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellInterface.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellInterface.java

@@ -16,7 +16,7 @@ public interface VrShellInterface {

/**

* Performs native VrShell initialization.

- void onNativeLibraryReady(Tab currentTab);

+ void initializeNative(Tab currentTab, VrShellDelegate delegate);

/**

* Pauses VrShell.

@@ -39,6 +39,11 @@ public interface VrShellInterface {

void setVrModeEnabled(boolean enabled);

/**

+ * Sets whether we're presenting WebVR content or not.

+ */

+ void setWebVrModeEnabled(boolean enabled);

+ /**

* Returns the GVRLayout as a FrameLayout.

FrameLayout getContainer();